-
Notifications
You must be signed in to change notification settings - Fork 10.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-enable the browsertests in Google Chrome on the Windows bot #14509
Comments
… Windows bot" This reverts commit d476186. The most recent Puppeteer version ships with the most recent Chrome version that should fix the problems we encountered before. Fixes mozilla#14509.
…hrome on the Windows bot (PR 14392 follow-up)" This reverts commit 18c295f. The most recent Puppeteer version ships with the most recent Chrome version that should fix the problems we encountered before. Fixes mozilla#14509.
It looks like Puppeteer 13.5.2 did improve things, but not up to the point that we can enable it again. The Windows bot did not fully timeout after 60 minutes anymore, but while completing it still took ~40 minutes and Chrome did eventually timeout in the tests themselves. |
Let's just WONTFIX this, since I don't think that it's really worth doubling the runtime of the Windows-bot just to improve testing in Google Chrome; please see PR #16490. |
In PR #14392 we disabled the affected configuration, since the Puppeteer update to version
> 13.1.0
caused the browsertests to run extremely slowly and then timeout in Google Chrome on the Windows bot.It's possible that this is either a bug in Google Chrome, in Puppeteer, or a combination of them both. In any case, we should figure out why this happens and report the bug(s) to the appropriate project(s). (Unless it turns out to be fixable directly in our test-suite, of course.)
The text was updated successfully, but these errors were encountered: