Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable the browsertests in Google Chrome on the Windows bot #14509

Closed
Snuffleupagus opened this issue Jan 27, 2022 · 2 comments
Closed

Re-enable the browsertests in Google Chrome on the Windows bot #14509

Snuffleupagus opened this issue Jan 27, 2022 · 2 comments

Comments

@Snuffleupagus
Copy link
Collaborator

In PR #14392 we disabled the affected configuration, since the Puppeteer update to version > 13.1.0 caused the browsertests to run extremely slowly and then timeout in Google Chrome on the Windows bot.

It's possible that this is either a bug in Google Chrome, in Puppeteer, or a combination of them both. In any case, we should figure out why this happens and report the bug(s) to the appropriate project(s). (Unless it turns out to be fixable directly in our test-suite, of course.)

timvandermeij added a commit to timvandermeij/pdf.js that referenced this issue Apr 2, 2022
… Windows bot"

This reverts commit d476186. The most
recent Puppeteer version ships with the most recent Chrome version that
should fix the problems we encountered before.

Fixes mozilla#14509.
timvandermeij added a commit to timvandermeij/pdf.js that referenced this issue Apr 2, 2022
…hrome on the Windows bot (PR 14392 follow-up)"

This reverts commit 18c295f. The most
recent Puppeteer version ships with the most recent Chrome version that
should fix the problems we encountered before.

Fixes mozilla#14509.
@timvandermeij
Copy link
Contributor

It looks like Puppeteer 13.5.2 did improve things, but not up to the point that we can enable it again. The Windows bot did not fully timeout after 60 minutes anymore, but while completing it still took ~40 minutes and Chrome did eventually timeout in the tests themselves.

@Snuffleupagus
Copy link
Collaborator Author

Let's just WONTFIX this, since I don't think that it's really worth doubling the runtime of the Windows-bot just to improve testing in Google Chrome; please see PR #16490.

@Snuffleupagus Snuffleupagus closed this as not planned Won't fix, can't repro, duplicate, stale May 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants