Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

St Josephs Hill park map has a bogus Õ character in title #4096

Closed
dholbert opened this issue Jan 9, 2014 · 3 comments
Closed

St Josephs Hill park map has a bogus Õ character in title #4096

dholbert opened this issue Jan 9, 2014 · 3 comments

Comments

@dholbert
Copy link

dholbert commented Jan 9, 2014

This PDF...
http://www.openspace.org/preserves/maps/pr_st_josephs.pdf
...renders with a weird "Õ" character in the title, in PDF.js.

This bogus character isn't shown in Evince or xpdf.

This affects the version of PDF.js currently shipped with Firefox Nightly, as well as the development version at http://mozilla.github.com/pdf.js/extensions/firefox/pdf.js.xpi (which reports itself as being version 0.8.845)

screenshot

@timvandermeij
Copy link
Contributor

I can replicate this using Windows 7 x64, Firefox 26.0 (HWA on) and the latest PDF.js development version. There are no console warnings/errors.

@Snuffleupagus
Copy link
Collaborator

The PDF file actually contains the Õ (O-tilde) character (I assume that the author intended it to be an apostrophe instead). This can be seen if you open the file in Adobe Reader, and then copy the title and paste it into e.g. a text editor.

The issue here is that the character shouldn't be rendered, because of various properties of the font data in the PDF file, but we currently don't handle this edge case correctly.

I've attempted to write a patch for this, but it doesn't currently make any sense to submit a PR since it would clash with the nice re-factoring being done in #4259. (Also, after that PR, the solution I attempted wouldn't work anyway.)

@timvandermeij
Copy link
Contributor

The PDF has been updated (does not match the screenshot anymore). Closing as fixed for now because there is no reference PDF anymore to test with. If anyone has a similar case that is still broken, we can reopen this.

yurydelendik added a commit to yurydelendik/pdf.js that referenced this issue Apr 2, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants