Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pdf.js does not show properly decimal points #4307

Closed
sejoon opened this issue Feb 17, 2014 · 13 comments
Closed

pdf.js does not show properly decimal points #4307

sejoon opened this issue Feb 17, 2014 · 13 comments

Comments

@sejoon
Copy link

sejoon commented Feb 17, 2014

Dear team

i'm using pdf.js to display Japanese pdf which includes decimal points.
Usually it works fine but sometimes if the pdf has decimal points(e.g. 34.2, 45.3), it does not show properly(It shows like 34 2, 45 3. Show blank instead of decimal point) even though when we display with Acrobat reader, it shows properly.

Is there any tips/workaround for this problem?

Regards
Ahn

@timvandermeij
Copy link
Contributor

We will need an example PDF in order to investigate this issue. Please provide one and also provide details about your configuration (OS name/version, browser name/version, PDF.js version).

@yurydelendik
Copy link
Contributor

@sejoon
Copy link
Author

sejoon commented Feb 19, 2014

Thanks for the response.
i prepared sample pdf file which shows the issue...
But... how can i upload the pdf file? i got message like the following.
"Unfortunately we don't support that file type yet. Please use PNG, GIF, or JPG."

  • Sorry for my very basic question...

Regarding configuration, this happens with the following environment.
PDF Viewer 0.8.649
https://addons.mozilla.org/ja/firefox/addon/pdfjs/
Browser : Firefox
OS : Windows 7.

@sejoon
Copy link
Author

sejoon commented Feb 19, 2014

Here is the sample file.
Hope this reply via mail can attach the pdf properly....

2014-02-18 22:51 GMT+09:00 Yury Delendik notifications@github.com:

Crosspost
https://groups.google.com/forum/#!topic/mozilla.dev.pdf-js/ITnfgj2S--c

Reply to this email directly or view it on GitHubhttps://github.com//issues/4307#issuecomment-35385446
.

//////////////////////////////
Sejoon Ahn
sejoon.ahn@gmail.com
//////////////////////////////

@timvandermeij
Copy link
Contributor

@sejoon You cannot attach a file via e-mail. To attach the PDF, please upload it to a service like Dropbox, Google Drive or Zippyshare and share the download link here.

@sejoon
Copy link
Author

sejoon commented Feb 20, 2014

Thanks Tim.

i uploaded the file here.
https://drive.google.com/file/d/0B9yn3KSGAKmUUm9veEVDRHA2Z2M/edit?usp=sharing

In the pdf, numbers like "43 2, 32 7, 43 1, 37 3" in the middle box miss decimal points.
It displays properly like "43.2, 32.7, 43.1, 37.3" when i check with Acrobat reader and also with Google drive's viewer.

Regards.
Ahn

@timvandermeij
Copy link
Contributor

Thanks for uploading the file. I can reproduce this using Windows 7 x64, Firefox Nightly 30.0a1 (64 bit, HWA on) and the latest PDF.js development version.

@timvandermeij
Copy link
Contributor

Fixed in the most recent version of PDF.js.

@sejoon
Copy link
Author

sejoon commented May 7, 2014

Dear team

What codes were changed for this correction?
Because i confirmed that this problem was solved by checking pdf js viewer (0.8.1334).
But if i just retrieve latest pdf.js, pdf.worker.js files (version 0.8.1334) and use these files with other programs(other viewer), still it shows same problem.

Very sorry for my basic questions but does someone tell me what codes were changed within lots of files in pdf js libraries or pdf js viewer?

Best Regards.
Ahn

@yurydelendik
Copy link
Contributor

Very sorry for my basic questions but does someone tell me what codes were changed within lots of files in pdf js libraries or pdf js viewer?

The code is changed by accepting pull requests (https://github.com/mozilla/pdf.js/pulls) Also you are welcome to use git log to find our who/when changed the code.

What codes were changed for this correction?

Looks like this was closed on "works for me" base. And Tim confirmed that it was broken 3 months ago and was fixed in a month locally, based on information you provided. Normally we specify what issues are fixed by which requests. But we have many duplicate issues and it's really hard to detect the duplication, and then identify which pull request fixed the issue. If needed, it requires time to do that, we can identify the change when we will have time.

But if i just retrieve latest pdf.js, pdf.worker.js files (version 0.8.1334) and use these files with other programs(other viewer), still it shows same problem.

You did not provide any information that you are using a custom solution. Can you reproduce the issue with the viewer at http://mozilla.github.io/pdf.js/web/viewer.html ? If not, looks like there is a problem on your side. See https://github.com/mozilla/pdf.js/wiki/Frequently-Asked-Questions#custom

@sejoon
Copy link
Author

sejoon commented May 7, 2014

Thanks Yuri for your sincere explanation.

i tried with the following viewer as you mentioned and it showed properly as pdf js viewer addon!
http://mozilla.github.io/pdf.js/web/viewer.html

So, it seems that the reason is purely custom solution side...
Let me try to find out what would be the cause of custom side by following your instructions - git log etc...

Best Regards.
Ahn

@yurydelendik
Copy link
Contributor

@sejoon my guess that your pdf was fixed by cmap pull request #4259. If you did not download cmap files, we package those with generic viewer, please do that. Also, specify their location at https://github.com/mozilla/pdf.js/blob/master/src/display/api.js#L38.

@sejoon
Copy link
Author

sejoon commented May 7, 2014

Thank you so much for your valuable advice!
Let me check and update to you.

Ahn

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants