-
Notifications
You must be signed in to change notification settings - Fork 10k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pdf.js does not show properly decimal points #4307
Comments
We will need an example PDF in order to investigate this issue. Please provide one and also provide details about your configuration (OS name/version, browser name/version, PDF.js version). |
Thanks for the response.
Regarding configuration, this happens with the following environment. |
Here is the sample file. 2014-02-18 22:51 GMT+09:00 Yury Delendik notifications@github.com:
////////////////////////////// |
@sejoon You cannot attach a file via e-mail. To attach the PDF, please upload it to a service like Dropbox, Google Drive or Zippyshare and share the download link here. |
Thanks Tim. i uploaded the file here. In the pdf, numbers like "43 2, 32 7, 43 1, 37 3" in the middle box miss decimal points. Regards. |
Thanks for uploading the file. I can reproduce this using Windows 7 x64, Firefox Nightly 30.0a1 (64 bit, HWA on) and the latest PDF.js development version. |
Fixed in the most recent version of PDF.js. |
Dear team What codes were changed for this correction? Very sorry for my basic questions but does someone tell me what codes were changed within lots of files in pdf js libraries or pdf js viewer? Best Regards. |
The code is changed by accepting pull requests (https://github.com/mozilla/pdf.js/pulls) Also you are welcome to use git log to find our who/when changed the code.
Looks like this was closed on "works for me" base. And Tim confirmed that it was broken 3 months ago and was fixed in a month locally, based on information you provided. Normally we specify what issues are fixed by which requests. But we have many duplicate issues and it's really hard to detect the duplication, and then identify which pull request fixed the issue. If needed, it requires time to do that, we can identify the change when we will have time.
You did not provide any information that you are using a custom solution. Can you reproduce the issue with the viewer at http://mozilla.github.io/pdf.js/web/viewer.html ? If not, looks like there is a problem on your side. See https://github.com/mozilla/pdf.js/wiki/Frequently-Asked-Questions#custom |
Thanks Yuri for your sincere explanation. i tried with the following viewer as you mentioned and it showed properly as pdf js viewer addon! So, it seems that the reason is purely custom solution side... Best Regards. |
@sejoon my guess that your pdf was fixed by cmap pull request #4259. If you did not download cmap files, we package those with generic viewer, please do that. Also, specify their location at https://github.com/mozilla/pdf.js/blob/master/src/display/api.js#L38. |
Thank you so much for your valuable advice! Ahn |
Dear team
i'm using pdf.js to display Japanese pdf which includes decimal points.
Usually it works fine but sometimes if the pdf has decimal points(e.g. 34.2, 45.3), it does not show properly(It shows like 34 2, 45 3. Show blank instead of decimal point) even though when we display with Acrobat reader, it shows properly.
Is there any tips/workaround for this problem?
Regards
Ahn
The text was updated successfully, but these errors were encountered: