Somehow store whether the contents/thumbnail sidebar is open

[ghost]

Proposal for a small UX enhancement:

I just had the experience that I:

1. opened a PDF file
2. opened the contents sidebar
3. navigated away from the PDF by clicking a link in it
4. navigated back to the PDF by clicking the browser's Back button

Result: the contents sidebar is not open anymore.

I think this issue might be solved relatively easily by adding #sidebar-content/#sidebar-thumbs to the URL when the sidebar is open. (And then of course changing the UI depending on that.)

But there might be better ways.

[timvandermeij]

Might be fixed in a similar way as #5949.

[ankitaggarwal011]

Anyone working on this? If no, I would like to try to fix this issue. Thanks!

[brendandahl]

Anyone working on this?

Not that I know of, feel free to take it on!

[ankitaggarwal011]

Thanks @brendandahl, since the user moves away from the PDF in this issue, would it be good idea to store the state of sidebar (openSidebar variable) in the local-storage of the browser and initialize sidebarOpen variable in viewer.js from local-storage if available. What do you think? Please let me know.

[brendandahl]

We have code already built to persistently store preferences. As Tim suggested above, this will be very similar to the fix in #6980 and I'd suggest looking at that.

[ankitaggarwal011]

Thanks. I will have a look and try to make the changes locally.

Update:
I have made the changes locally, I have tested them and are working as intended. It passes all the unit tests. I am opening a PR for the same. Please review the changes. Thanks.