Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the remaining lint errors in the URL polyfill #7978

Closed
Snuffleupagus opened this issue Jan 21, 2017 · 0 comments
Closed

Fix the remaining lint errors in the URL polyfill #7978

Snuffleupagus opened this issue Jan 21, 2017 · 0 comments

Comments

@Snuffleupagus
Copy link
Collaborator

When switching to ESLint, the yoda rule was temporarily disabled for the URL polyfill.
Those linting errors should be fixed, so that the exception can be removed.

In order to address this issue:

  1. Remove lines src/shared/util.js#L1758-L1759 and src/shared/util.js#L2396-L2397.
  2. Run linting locally, using gulp lint, to find the errors.
  3. Fix the errors reported by ESLint.

For more information about the contributing workflow, please refer to https://github.com/mozilla/pdf.js/wiki/Contributing and https://github.com/mozilla/pdf.js#getting-the-code.

Snuffleupagus added a commit that referenced this issue Jan 21, 2017
Fix #7978: Fixes ESLint yoda rule for the URL polyfill.
movsb pushed a commit to movsb/pdf.js that referenced this issue Jul 14, 2018
movsb pushed a commit to movsb/pdf.js that referenced this issue Jul 14, 2018
Fix mozilla#7978: Fixes ESLint yoda rule for the URL polyfill.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant