Ensure that attempting to print with disableAutoFetch set will fail gracefully (issue 11339)
#11346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… gracefully (issue 11339) This patch simply restores the behaviour that existed prior to PR 7697, since I cannot imagine that that was changed other than by pure accident. As mentioned by a comment in `BaseViewer.setDocument`: "Printing is semi-broken with auto fetch disabled.", and note that since triggering of printing is a synchronous operation there's generally no easy way to load the missing data. https://github.com/mozilla/pdf.js/pull/7697/files#diff-529d1853ee1bba753a0fcb40ea778723L1114-L1118
Snuffleupagus
force-pushed
the
pageViewsReady-printing
branch
from
917f018
to
0b0bf71
Compare
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/04b4b2ea2ef50fa/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/04b4b2ea2ef50fa/output.txt Total script time: 1.72 mins Published |
timvandermeij
approved these changes
Nov 19, 2019
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch simply restores the behaviour that existed prior to PR #7697, see this code in particular, since I cannot imagine that that was changed other than by pure accident.
As mentioned by a comment in
BaseViewer.setDocument: "Printing is semi-broken with auto fetch disabled.", and note that since triggering of printing is a synchronous operation there's generally no easy way to load the missing data.Fixes #11339