[api-minor] Remove SystemJS usage, in development mode, from the worker #12563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Snuffleupagus
force-pushed
the
rm-SystemJS-worker
branch
from
74e19ed
to
37162b5
Compare
Snuffleupagus
force-pushed
the
rm-SystemJS-worker
branch
from
37162b5
to
2cb7fe0
Compare
Snuffleupagus
force-pushed
the
rm-SystemJS-worker
branch
from
2cb7fe0
to
229ef40
Compare
Snuffleupagus
force-pushed
the
rm-SystemJS-worker
branch
from
229ef40
to
47b5e02
Compare
Snuffleupagus
force-pushed
the
rm-SystemJS-worker
branch
3 times, most recently
from
d4edbdc
to
e9b7843
Compare
Snuffleupagus
force-pushed
the
rm-SystemJS-worker
branch
from
e9b7843
to
6023063
Compare
Snuffleupagus
force-pushed
the
rm-SystemJS-worker
branch
from
6023063
to
dca3b31
Compare
Snuffleupagus
force-pushed
the
rm-SystemJS-worker
branch
2 times, most recently
from
ec02d34
to
e9b8fbd
Compare
Snuffleupagus
force-pushed
the
rm-SystemJS-worker
branch
3 times, most recently
from
744a84c
to
18e997d
Compare
Snuffleupagus
force-pushed
the
rm-SystemJS-worker
branch
from
18e997d
to
5105a5c
Compare
Snuffleupagus
force-pushed
the
rm-SystemJS-worker
branch
2 times, most recently
from
dbdf30e
to
1d61a58
Compare
Snuffleupagus
force-pushed
the
rm-SystemJS-worker
branch
2 times, most recently
from
70a9b32
to
1ebc9a7
Compare
Snuffleupagus
force-pushed
the
rm-SystemJS-worker
branch
2 times, most recently
from
5d0cc0c
to
02c4569
Compare
Snuffleupagus
force-pushed
the
rm-SystemJS-worker
branch
from
02c4569
to
0ba8de5
Compare
Snuffleupagus
force-pushed
the
rm-SystemJS-worker
branch
3 times, most recently
from
3e6abdf
to
18bf0e1
Compare
Snuffleupagus
force-pushed
the
rm-SystemJS-worker
branch
from
18bf0e1
to
80fd9c6
Compare
Snuffleupagus
force-pushed
the
rm-SystemJS-worker
branch
7 times, most recently
from
ee59c4d
to
35deb8e
Compare
Snuffleupagus
force-pushed
the
rm-SystemJS-worker
branch
2 times, most recently
from
4292d63
to
5cb7023
Compare
Now that https://bugzilla.mozilla.org/show_bug.cgi?id=1247687 has landed in Firefox, we're able to use worker-modules during development :-) This removes the final piece of SystemJS usage from the PDF.js library, thus allowing a fair bit of clean-up, and we now use *only* native `import`/`export` statements everywhere in development mode.
… to re-format `src/core/{glyphlist, unicode}.js`"
This reverts commit 56fa6d4 now that SystemJS is gone.
…apability` class This is not only slightly more compact, but it also simplifies the handling of the `settled` getter.
…read Now that we no longer depend on the old Babel version in SystemJS we can remove the `static get ...` work-arounds used to define constants, which leads to slightly more compact code.
Snuffleupagus
force-pushed
the
rm-SystemJS-worker
branch
from
5cb7023
to
88616f7
Compare
|
https://bugzilla.mozilla.org/show_bug.cgi?id=1812591 has now landed in Firefox Nightly, see also https://groups.google.com/a/mozilla.org/g/dev-platform/c/J5zqdaNSpAM, which should've been the final blocker for this PR :-) Please note: This patch only introduces worker modules for the development viewer, i.e. |
calixteman
approved these changes
May 3, 2023
|
/botio test |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/92fc4d70c7aa33f/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/aa34e9d32a22860/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/aa34e9d32a22860/output.txt Total script time: 27.30 mins
Image differences available at: http://54.241.84.105:8877/aa34e9d32a22860/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/92fc4d70c7aa33f/output.txt Total script time: 34.05 mins
Image differences available at: http://54.193.163.58:8877/92fc4d70c7aa33f/reftest-analyzer.html#web=eq.log |
|
Nice work, and really good to get rid of SystemJS now! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that https://bugzilla.mozilla.org/show_bug.cgi?id=1247687 has landed in Firefox, we're able to use worker-modules during development :-)
This removes the final piece of SystemJS usage from the PDF.js library, thus allowing a fair bit of clean-up, and we now use only native
import/exportstatements everywhere in development mode.