Implement unit tests for the parseQueryString utility function
#13837
Conversation
timvandermeij
force-pushed
the
unit-test-query-string
branch
from
e8a2788
to
ea5fbb8
Compare
|
/botio unittest |
From: Bot.io (Linux m4)ReceivedCommand cmd_unittest from @timvandermeij received. Current queue size: 0 Live output at: http://54.67.70.0:8877/e9df1882354ef1e/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_unittest from @timvandermeij received. Current queue size: 0 Live output at: http://3.101.106.178:8877/a11c68f3468d97f/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/e9df1882354ef1e/output.txt Total script time: 3.78 mins
|
From: Bot.io (Windows)SuccessFull output at http://3.101.106.178:8877/a11c68f3468d97f/output.txt Total script time: 5.21 mins
|
Now that these unit tests are in place, we also take the opportunity to slightly modernize the code itself by using a `for ... of` loop.
timvandermeij
force-pushed
the
unit-test-query-string
branch
from
ea5fbb8
to
d1c0f8f
Compare
|
/botio unittest |
From: Bot.io (Windows)ReceivedCommand cmd_unittest from @timvandermeij received. Current queue size: 0 Live output at: http://3.101.106.178:8877/aee05f8ab56eee9/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_unittest from @timvandermeij received. Current queue size: 0 Live output at: http://54.67.70.0:8877/296117939f1efac/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/296117939f1efac/output.txt Total script time: 3.76 mins
|
From: Bot.io (Windows)FailedFull output at http://3.101.106.178:8877/aee05f8ab56eee9/output.txt Total script time: 5.50 mins
|
|
The last unit test run failed because of a newly added unit test, |
Now that these unit tests are in place, we also take the opportunity to slightly modernize the code itself by using a
for ... ofloop.(I noticed after the
Mapchange that this function did not have unit test coverage yet, so I thought it would be good to add that, especially considering the specialdecodeURIComponent(null)case so that the unit tests assert that we don't accidentally return"null"anymore.)