Move some validation, in Dict.merge, used during merging of sub-dictionaries (PR 13775 follow-up)
#13892
Conversation
…tionaries (PR 13775 follow-up) By not adding any additional non-`Dict` entries to the list of candidates for merging of sub-dictionaries, we can very slightly reduce the amount of parsing required by not having to *again* iterate through unmergeable data.
|
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/785fc167032c5ae/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://3.101.106.178:8877/d9196a0ddbfd03f/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.67.70.0:8877/785fc167032c5ae/output.txt Total script time: 33.67 mins
Image differences available at: http://54.67.70.0:8877/785fc167032c5ae/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://3.101.106.178:8877/d9196a0ddbfd03f/output.txt Total script time: 39.47 mins
Image differences available at: http://3.101.106.178:8877/d9196a0ddbfd03f/reftest-analyzer.html#web=eq.log |
|
Thanks! Let's make new images after the Firefox update: |
From: Bot.io (Windows)ReceivedCommand cmd_makeref from @timvandermeij received. Current queue size: 2 Live output at: http://3.101.106.178:8877/118f6137a94783c/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_makeref from @timvandermeij received. Current queue size: 0 Live output at: http://54.67.70.0:8877/b19b2bddf247605/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.67.70.0:8877/b19b2bddf247605/output.txt Total script time: 24.04 mins
|
From: Bot.io (Windows)SuccessFull output at http://3.101.106.178:8877/118f6137a94783c/output.txt Total script time: 36.28 mins
|
|
/botio-linux makeref |
From: Bot.io (Linux m4)ReceivedCommand cmd_makeref from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/13978f41f65a376/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/13978f41f65a376/output.txt Total script time: 30.17 mins
|
By not adding any additional non-
Dictentries to the list of candidates for merging of sub-dictionaries, we can very slightly reduce the amount of parsing required by not having to again iterate through unmergeable data.