Export the XFA/StructTree-layers in the viewer components #13942
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While e.g. the `simpleviewer` and `singlepageviewer` examples work, since they're based on the `BaseViewer`-class, the standalone `pageviewer` example currently doesn't support either XFA- or StructTree-layers. This seems like an obvious oversight, which can be easily addressed simply by exporting the necessary functionality through `pdf_viewer.component.js`, similar to the existing Text/Annotation-layers. While working on, and testing, these changes I happened to notice a number of smaller things that's also fixed in this patch: - Ensure that `XfaLayerBuilder.render` always have a *consistent* return type, to prevent possible run-time failures in `PDFPageView`; PR 13908 follow-up. - Change the order of the options in the `XfaLayerBuilder`-constructor to agree with the parameter order in the `DefaultXfaLayerFactory.createXfaLayerBuilder`-method. - Add a missing `textHighlighterFactory`-option, in the JSDocs for the `PDFPageView`-class. - A couple of small tweaks in the `TextLayerBuilder.render`-method: Re-use an existing Array rather than creating a new one, and replace an `if` with optional chaining instead. *Please note:* For now XFA-support is currently disabled by default, similar to the regular viewer.
Snuffleupagus
force-pushed
the
viewer-components-export-layers
branch
from
b493412
to
c6d400e
Compare
|
/botio integrationtest |
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @Snuffleupagus received. Current queue size: 0 Live output at: http://3.101.106.178:8877/99f9664b60f1e7c/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/4d8da4438723f6c/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/4d8da4438723f6c/output.txt Total script time: 4.50 mins
|
From: Bot.io (Windows)SuccessFull output at http://3.101.106.178:8877/99f9664b60f1e7c/output.txt Total script time: 5.47 mins
|
timvandermeij
approved these changes
Aug 29, 2021
|
Thank you for improving this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While e.g. the
simpleviewerandsinglepageviewerexamples work, since they're based on theBaseViewer-class, the standalonepageviewerexample currently doesn't support either XFA- or StructTree-layers. This seems like an obvious oversight, which can be easily addressed simply by exporting the necessary functionality throughpdf_viewer.component.js, similar to the existing Text/Annotation-layers.While working on, and testing, these changes I happened to notice a number of smaller things that's also fixed in this patch:
Ensure that
XfaLayerBuilder.renderalways have a consistent return type, to prevent possible run-time failures inPDFPageView; PR [api-minor] XFA - Support text search in XFA documents. #13908 follow-up.Change the order of the options in the
XfaLayerBuilder-constructor to agree with the parameter order in theDefaultXfaLayerFactory.createXfaLayerBuilder-method.Add a missing
textHighlighterFactory-option, in the JSDocs for thePDFPageView-class.A couple of small tweaks in the
TextLayerBuilder.render-method: Re-use an existing Array rather than creating a new one, and replace anifwith optional chaining instead.Please note: For now XFA-support is currently disabled by default, similar to the regular viewer.