Write boolean value when saving a form (bug 1729971) #13998
Conversation
calixteman
commented
Sep 10, 2021
calixteman
commented
- it aims to fix https://bugzilla.mozilla.org/show_bug.cgi?id=1729971#c4.
|
/botio unittest |
From: Bot.io (Linux m4)ReceivedCommand cmd_unittest from @calixteman received. Current queue size: 1 Live output at: http://54.241.84.105:8877/ca07fb9b0d7e27f/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_unittest from @calixteman received. Current queue size: 2 Live output at: http://54.193.163.58:8877/9a1439ec2ba8769/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/ca07fb9b0d7e27f/output.txt Total script time: 2.82 mins
|
| @@ -83,10 +83,14 @@ function writeValue(value, buffer, transform) { | |||
| buffer.push(`(${escapeString(value)})`); | |||
| } else if (typeof value === "number") { | |||
| buffer.push(numberToString(value)); | |||
| } else if (typeof value === "boolean") { | |||
| buffer.push(`${value.toString()}`); | |||
There was a problem hiding this comment.
I might be missing something obvious here, but why do you need to wrap this in a string?
Isn't value.toString() already a string, in which case just buffer.push(value.toString()); ought to work.
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/9a1439ec2ba8769/output.txt Total script time: 7.00 mins
|
|
Looks good to me too with the comment above addressed. |
|
Actually, let's land this as-is such that it won't just miss the upcoming release and we can fix the comment in a follow-up. |
