Re-factor the EventBus and isInAutomation handling (PR 11655 follow-up)
#14043
Conversation
…ow-up) Rather than forcing the "regular" `EventBus` to check and handle `isInAutomation` for every `dispatch` call, we can take advantage of subclassing instead. Hence this PR introduces a new `AutomationEventBus` class, which extends `EventBus`, and is used by the default viewer when `isInAutomation === true`.
|
/botio unittest |
From: Bot.io (Linux m4)ReceivedCommand cmd_unittest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/b7b6698233a7acd/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_unittest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/37cc6f1bc868342/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/b7b6698233a7acd/output.txt Total script time: 2.76 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/37cc6f1bc868342/output.txt Total script time: 5.51 mins
|
|
/botio integrationtest |
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/e3a48037250d29c/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/b8074535171b8d3/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/e3a48037250d29c/output.txt Total script time: 3.47 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/b8074535171b8d3/output.txt Total script time: 6.07 mins
|
|
Thank you for simplifying this! |
Rather than forcing the "regular"
EventBusto check and handleisInAutomationfor everydispatchcall, we can take advantage of subclassing instead.Hence this PR introduces a new
AutomationEventBusclass, which extendsEventBus, and is used by the default viewer whenisInAutomation === true.