Add PDF_TO_CSS_UNITS to the PixelsPerInch-structure
#14055
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rather than re-computing this value in a number of different places throughout the code-base[1], we can expose this in the API via the existing `PixelsPerInch`-structure instead. There's also been feature requests asking for the old `CSS_UNITS` viewer constant to be made accessible, such that it could be used in third-party implementations. I suppose that it could be argued that it's somewhat confusing to place a unitless property in `PixelsPerInch`, however given that the `PDF_TO_CSS_UNITS`-property is defined strictly in terms of the existing properties this is hopefully deemed reasonable. --- [1] These include: - The viewer, with the `CSS_UNITS` name. - The reference-tests. - The display-layer, when rendering images; see PR 13991.
|
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/5cd0b17478d0a77/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/b8412e4238e540a/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/5cd0b17478d0a77/output.txt Total script time: 21.73 mins
Image differences available at: http://54.241.84.105:8877/5cd0b17478d0a77/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/b8412e4238e540a/output.txt Total script time: 39.49 mins
Image differences available at: http://54.193.163.58:8877/b8412e4238e540a/reftest-analyzer.html#web=eq.log |
timvandermeij
approved these changes
Sep 22, 2021
|
Looks good to me; thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than re-computing this value in a number of different places throughout the code-base[1], we can expose this in the API via the existing
PixelsPerInch-structure instead.There's also been feature requests asking for the old
CSS_UNITSviewer constant to be made accessible, such that it could be used in third-party implementations.I suppose that it could be argued that it's somewhat confusing to place a unitless property in
PixelsPerInch, however given that thePDF_TO_CSS_UNITS-property is defined strictly in terms of the existing properties this is hopefully deemed reasonable.[1] These include:
CSS_UNITSname.