Apply transfer filters to any graphic commands

[calixteman]

No description provided.

[Snuffleupagus]

As far as I can tell, this won't actually work in environments without OffscreenCanvas support (i.e. older browsers and Node.js); do we consider that to be a problem?
My gut feeling is that the answer is no, especially considering just how rare transferMaps are in practice, but I wanted to ask nonetheless.

[calixteman]

Good question.
Right now, you're right because I expected to only have transfer maps with images, hence the filter factory is only created when we've OffscreenCanvas.
So we could just always have the filter factory and only keep a ref on the maps array when we're in non-offscreencanvas mode.
Wdyt of filing a bug for this case and I'll fix that later (or someone else could it, it could be a good first bug) ?

[Snuffleupagus]

So we could just always have the filter factory and only keep a ref on the maps array when we're in non-offscreencanvas mode.

This situation seems to (mostly) apply to Node.js, and it's not clear to me if the node-canvas package first of all supports canvas-filters at all. Secondly the FilterFactory will definitely not work in Node.js, and it's again not clear to me if a Node-version of that code could actually be (easily) created.

Wdyt of filing a bug for this case and I'll fix that later (or someone else could it, it could be a good first bug) ?

Given the points above, I'm somewhat doubtful if we can even make it work (for Node.js) and thus it's probably not a good beginner bug unfortunately.

[Snuffleupagus]

Also, do we need to include the filter when copying the canvas state?

pdf.js/src/display/canvas.js

Lines 828 to 840 in e11371c

	function copyCtxState(sourceCtx, destCtx) {
	const properties = [
	"strokeStyle",
	"fillStyle",
	"fillRule",
	"globalAlpha",
	"lineWidth",
	"lineCap",
	"lineJoin",
	"miterLimit",
	"globalCompositeOperation",
	"font",
	];

[calixteman]

/botio test

[pdfjsbot]

From: Bot.io (Linux m4)

---

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/614c9287dfef61c/output.txt

[pdfjsbot]

From: Bot.io (Windows)

---

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/991d7b8748074a7/output.txt

[pdfjsbot]

From: Bot.io (Linux m4)

---

Failed

Full output at http://54.241.84.105:8877/614c9287dfef61c/output.txt

Total script time: 27.11 mins

• Font tests: Passed
• Unit tests: Passed
• Integration Tests: FAILED
• Regression tests: FAILED

  different ref/snapshot: 10
  different first/second rendering: 1

Image differences available at: http://54.241.84.105:8877/614c9287dfef61c/reftest-analyzer.html#web=eq.log

[pdfjsbot]

From: Bot.io (Windows)

---

Failed

Full output at http://54.193.163.58:8877/991d7b8748074a7/output.txt

Total script time: 32.87 mins

• Font tests: Passed
• Unit tests: Passed
• Integration Tests: FAILED
• Regression tests: FAILED

  different ref/snapshot: 28

Image differences available at: http://54.193.163.58:8877/991d7b8748074a7/reftest-analyzer.html#web=eq.log

[Snuffleupagus]

r=me, with passing tests; thank you!

[calixteman]

/botio test

[pdfjsbot]

From: Bot.io (Linux m4)

---

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/c30d66f7338cf21/output.txt

[pdfjsbot]

From: Bot.io (Windows)

---

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/d3e2962ac6bc42b/output.txt

[pdfjsbot]

From: Bot.io (Linux m4)

---

Failed

Full output at http://54.241.84.105:8877/c30d66f7338cf21/output.txt

Total script time: 26.75 mins

• Font tests: Passed
• Unit tests: Passed
• Integration Tests: Passed
• Regression tests: FAILED

  different ref/snapshot: 10
  different first/second rendering: 1

Image differences available at: http://54.241.84.105:8877/c30d66f7338cf21/reftest-analyzer.html#web=eq.log

[pdfjsbot]

From: Bot.io (Windows)

---

Failed

Full output at http://54.193.163.58:8877/d3e2962ac6bc42b/output.txt

Total script time: 33.53 mins

• Font tests: Passed
• Unit tests: Passed
• Integration Tests: FAILED
• Regression tests: FAILED

  different ref/snapshot: 32

Image differences available at: http://54.193.163.58:8877/d3e2962ac6bc42b/reftest-analyzer.html#web=eq.log

[calixteman]

/botio makeref

[pdfjsbot]

From: Bot.io (Linux m4)

---

Received

Command cmd_makeref from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/49458dc44daf339/output.txt

[pdfjsbot]

From: Bot.io (Windows)

---

Received

Command cmd_makeref from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/497452f070874c5/output.txt

[pdfjsbot]

From: Bot.io (Linux m4)

---

Success

Full output at http://54.241.84.105:8877/49458dc44daf339/output.txt

Total script time: 22.77 mins

• Lint: Passed
• Make references: Passed
• Check references: Passed

[pdfjsbot]

From: Bot.io (Windows)

---

Failed

Full output at http://54.193.163.58:8877/497452f070874c5/output.txt

Total script time: 23.81 mins

• Lint: Passed
• Make references: FAILED

[calixteman]

I had frequently this error with Firefox and local dev but when I switched to workerModule=true it disappeared.
@Snuffleupagus, should we enable workerModule for tests either ?

[calixteman]

/botio-windows makeref

[pdfjsbot]

From: Bot.io (Windows)

---

Received

Command cmd_makeref from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/80df97a5578dcf3/output.txt

[Snuffleupagus]

I had frequently this error with Firefox and local dev but when I switched to workerModule=true it disappeared. @Snuffleupagus, should we enable workerModule for tests either ?

I don't understand how that option matters for the browser-tests, since the default viewer isn't actually being used there (the tests call the API directly).

[pdfjsbot]

From: Bot.io (Windows)

---

Success

Full output at http://54.193.163.58:8877/80df97a5578dcf3/output.txt

Total script time: 23.97 mins

• Lint: Passed
• Make references: Passed
• Check references: Passed