Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply HCM filters on annotations which have their own canvas (bug 1830850) #16380

Merged
merged 1 commit into from
May 3, 2023

Conversation

calixteman
Copy link
Contributor

No description provided.

Copy link
Collaborator

@Snuffleupagus Snuffleupagus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me, with passing tests; thank you!

@calixteman
Copy link
Contributor Author

/botio test

@calixteman
Copy link
Contributor Author

Still the same error (rate limit).

@Snuffleupagus
Copy link
Collaborator

Given the problems with the bots, and the relatively small size of this patch (with the functionality being limited to annotations), I've just tested this locally on Windows 11; with the exception of the "usual" intermittent failures this seems to work just fine.

@calixteman If you've also successfully tested this locally, please feel free to land this patch without waiting for the bots to start working again!

@calixteman
Copy link
Contributor Author

I tried with my own account but I didn't a way to have the write permission (to add a comment) for this repo.
We need to wait for tomorrow and we should be able to have a bot account we already used with enough (I hope) permissions.
Sorry about that.

@mozilla mozilla deleted a comment from moz-tools-bot May 3, 2023
@mozilla mozilla deleted a comment from pdfjsbot May 3, 2023
@mozilla mozilla deleted a comment from moz-tools-bot May 3, 2023
@mozilla mozilla deleted a comment from pdfjsbot May 3, 2023
@calixteman
Copy link
Contributor Author

/botio test

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/822792b5c4dcf7c/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/ef5370d54f7d743/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Failed

Full output at http://54.241.84.105:8877/ef5370d54f7d743/output.txt

Total script time: 27.60 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: FAILED
  • Regression tests: FAILED
  different ref/snapshot: 9
  different first/second rendering: 2

Image differences available at: http://54.241.84.105:8877/ef5370d54f7d743/reftest-analyzer.html#web=eq.log

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Failed

Full output at http://54.193.163.58:8877/822792b5c4dcf7c/output.txt

Total script time: 32.93 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: FAILED
  • Regression tests: FAILED
  different ref/snapshot: 24

Image differences available at: http://54.193.163.58:8877/822792b5c4dcf7c/reftest-analyzer.html#web=eq.log

@calixteman calixteman merged commit ade1e52 into mozilla:master May 3, 2023
@calixteman
Copy link
Contributor Author

/botio makeref

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Received

Command cmd_makeref from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/7b850b1e9deffc3/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Received

Command cmd_makeref from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/527f6f8c4a9f502/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Success

Full output at http://54.241.84.105:8877/527f6f8c4a9f502/output.txt

Total script time: 22.89 mins

  • Lint: Passed
  • Make references: Passed
  • Check references: Passed

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Success

Full output at http://54.193.163.58:8877/7b850b1e9deffc3/output.txt

Total script time: 23.76 mins

  • Lint: Passed
  • Make references: Passed
  • Check references: Passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants