-
Notifications
You must be signed in to change notification settings - Fork 10k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix new intermittent failures with ink and stamp tests #17051
Conversation
/botio integrationtest |
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @calixteman received. Current queue size: 0 Live output at: http://54.241.84.105:8877/a82348ce19a60a7/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @calixteman received. Current queue size: 0 Live output at: http://54.193.163.58:8877/cbeb3d5cecabff1/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/a82348ce19a60a7/output.txt Total script time: 5.87 mins
|
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/cbeb3d5cecabff1/output.txt Total script time: 22.89 mins
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
r=me, thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me too, with the comment above addressed. I'm happy we're getting the intermittent integration test failures more under control now.
358e767
to
07381a4
Compare
/botio integrationtest |
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @calixteman received. Current queue size: 0 Live output at: http://54.193.163.58:8877/45940b168702f38/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @calixteman received. Current queue size: 0 Live output at: http://54.241.84.105:8877/9c236563a4c5822/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/9c236563a4c5822/output.txt Total script time: 5.46 mins
|
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/45940b168702f38/output.txt Total script time: 18.83 mins
|
07381a4
to
c5ce053
Compare
/botio-windows integrationtest |
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @calixteman received. Current queue size: 0 Live output at: http://54.193.163.58:8877/be4b738d31b34a2/output.txt |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/be4b738d31b34a2/output.txt Total script time: 19.12 mins
|
It happens only on windows with chrome. For any reason, click event isn't correctly triggered and it seems work correctly with pointerup. And it seems that when drawing a svg on an OffscreenCanvas we need to wait a little in order to be able to transfer it: it's why this patch adds a check on the canvas content.
c5ce053
to
077d239
Compare
/botio integrationtest |
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @calixteman received. Current queue size: 0 Live output at: http://54.241.84.105:8877/047caa3146517f3/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @calixteman received. Current queue size: 0 Live output at: http://54.193.163.58:8877/823fbe355e4bba6/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/047caa3146517f3/output.txt Total script time: 6.10 mins
|
/botio integrationtest |
1 similar comment
/botio integrationtest |
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @calixteman received. Current queue size: 0 Live output at: http://54.241.84.105:8877/86738caadb7fd3a/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @calixteman received. Current queue size: 0 Live output at: http://54.193.163.58:8877/8abecf729a6e5ac/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/86738caadb7fd3a/output.txt Total script time: 6.04 mins
|
Something is wrong with the bot account, because I got an error: |
It happens only on windows with chrome.
For any reason, click event isn't correctly triggered and it seems work correctly with pointerup.
And it seems that when drawing a svg on an OffscreenCanvas we need to wait a little in order to be able to transfer it: it's why this patch adds a check on the canvas content.