Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throw a JpegError when a JPEG image has no frame data (issue 17302) #17303

Merged
merged 1 commit into from
Nov 20, 2023

Conversation

Snuffleupagus
Copy link
Collaborator

Given that there's nothing to parse in this case, since we're dealing with an invalid JPEG image, throwing an explicit Error makes sense here.

Given that there's nothing to parse in this case, since we're dealing with an invalid JPEG image, throwing an *explicit* Error makes sense here.
@Snuffleupagus
Copy link
Collaborator Author

/botio test

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/f2838404eff167f/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.193.163.58:8877/a35fade86eb53ca/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Failed

Full output at http://54.241.84.105:8877/f2838404eff167f/output.txt

Total script time: 24.77 mins

  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: FAILED
  different ref/snapshot: 16

Image differences available at: http://54.241.84.105:8877/f2838404eff167f/reftest-analyzer.html#web=eq.log

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Failed

Full output at http://54.193.163.58:8877/a35fade86eb53ca/output.txt

Total script time: 34.43 mins

  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: FAILED
  different ref/snapshot: 21

Image differences available at: http://54.193.163.58:8877/a35fade86eb53ca/reftest-analyzer.html#web=eq.log

Copy link
Contributor

@calixteman calixteman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure that it's so useful to throw here instead of throwing at the next line...
That said it doesn't really hurt.
LGTM. Thank you.

@Snuffleupagus
Copy link
Collaborator Author

I'm not sure that it's so useful to throw here instead of throwing at the next line...

Agreed; the only reason that I think this makes sense to do here is because we're publishing the PDF.js image decoders separately in pdfjs-dist, see https://github.com/mozilla/pdfjs-dist/tree/master/image_decoders

@Snuffleupagus Snuffleupagus merged commit 086a592 into mozilla:master Nov 20, 2023
9 checks passed
@Snuffleupagus Snuffleupagus deleted the issue-17302 branch November 20, 2023 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeError: Cannot read properties of undefined (reading 'samplesPerLine')
3 participants