Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Editor] Always give the focus to the ink editor when starting drawing (bug 1867588) #17375

Merged
merged 1 commit into from
Dec 5, 2023
Merged

[Editor] Always give the focus to the ink editor when starting drawing (bug 1867588) #17375

merged 1 commit into from
Dec 5, 2023

Conversation

calixteman
Copy link
Contributor

This way, when the editor is blurred, it can be committed and everything works fine.
It fixes issue #17373.

@calixteman calixteman linked an issue Dec 4, 2023 that may be closed by this pull request
Editor cannot be selected, and editing-state getting mixed up #17373
Closed
@Snuffleupagus
Copy link
Collaborator

/botio-linux preview

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_preview from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/bc1404eda95fdec/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/bc1404eda95fdec/output.txt

Total script time: 1.40 mins

Published

Snuffleupagus
Snuffleupagus approved these changes Dec 5, 2023
View reviewed changes
Copy link
Collaborator

@Snuffleupagus Snuffleupagus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't forget to re-enable all integration tests.

r=me, thank you!

test/integration/ink_editor_spec.mjs Outdated Show resolved Hide resolved
@calixteman
[Editor] Always give the focus to the ink editor when starting drawin…
11610a9 
…g (bug 1867588)

This way, when the editor is blurred, it can be committed and everything works fine.
It fixes issue mozilla#17373.
@calixteman
Copy link
Contributor Author

/botio integrationtest

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/cb576c7d12d21ca/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/dd3887d3a5e37eb/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/cb576c7d12d21ca/output.txt

Total script time: 5.64 mins

  • Integration Tests: Passed

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Success

Full output at http://54.193.163.58:8877/dd3887d3a5e37eb/output.txt

Total script time: 17.89 mins

  • Integration Tests: Passed

@calixteman calixteman merged commit 795c63e into mozilla:master Dec 5, 2023
9 checks passed
@calixteman calixteman deleted the bug1867588 branch December 5, 2023 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Snuffleupagus Snuffleupagus Snuffleupagus approved these changes

Assignees
No one assigned
Labels
editor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Editor cannot be selected, and editing-state getting mixed up
3 participants
@calixteman @Snuffleupagus @moz-tools-bot