Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Editor] Change the arrow direction when the dropdown is visible in the color picker (bug 1875357) #17534

Merged
merged 1 commit into from
Jan 19, 2024
Merged

[Editor] Change the arrow direction when the dropdown is visible in the color picker (bug 1875357) #17534

merged 1 commit into from
Jan 19, 2024

Conversation

calixteman
Copy link
Contributor

and hide the dropdown when the user click outside of the color picker.

Snuffleupagus
Snuffleupagus requested changes Jan 18, 2024
View reviewed changes
src/display/editor/color_picker.js Outdated Show resolved Hide resolved
Snuffleupagus
Snuffleupagus approved these changes Jan 18, 2024
View reviewed changes
Copy link
Collaborator

@Snuffleupagus Snuffleupagus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me, thank you!

web/annotation_editor_layer_builder.css Outdated Show resolved Hide resolved
@calixteman
Copy link
Contributor Author

/botio integrationtest

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/8cc3a8c0fed4ee4/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/8a520dc9b849eeb/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/8a520dc9b849eeb/output.txt

Total script time: 6.71 mins

  • Integration Tests: FAILED

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/8cc3a8c0fed4ee4/output.txt

Total script time: 17.47 mins

  • Integration Tests: FAILED

@calixteman
Copy link
Contributor Author

/botio integrationtest

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 1

Live output at: http://54.241.84.105:8877/d090653bba12633/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 1

Live output at: http://54.193.163.58:8877/2218487865c94e6/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/d090653bba12633/output.txt

Total script time: 6.13 mins

  • Integration Tests: Passed

@calixteman
[Editor] Change the arrow direction when the dropdown is visible in t…
a1bf125 
…he color picker (bug 1875357)

and hide the dropdown when the user click outside of the color picker.
@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/2218487865c94e6/output.txt

Total script time: 17.31 mins

  • Integration Tests: FAILED

@calixteman calixteman merged commit a0e2b62 into mozilla:master Jan 19, 2024
9 checks passed
@calixteman calixteman deleted the bug1875357 branch January 19, 2024 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Snuffleupagus Snuffleupagus Snuffleupagus approved these changes

Assignees
No one assigned
Labels
editor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@calixteman @moz-tools-bot @Snuffleupagus