Avoid to have focused tests in using eslint-plugin-jasmine #17548

calixteman · 2024-01-20T20:49:32Z

No description provided.

package.json

test/.eslintrc

timvandermeij

Looks good me me; thank you for doing this! In this particular case I'm not too worried about the period without updates for the plugin because it doesn't seem to pull in any (pinned) dependencies itself which is usually what is causing problems.

calixteman added the other label Jan 20, 2024

calixteman requested review from timvandermeij and Snuffleupagus January 20, 2024 20:49

Snuffleupagus reviewed Jan 20, 2024

View reviewed changes

package.json Show resolved Hide resolved

test/.eslintrc Outdated Show resolved Hide resolved

test/.eslintrc Show resolved Hide resolved

Avoid to have focused tests in using eslint-plugin-jasmine

99ee308

calixteman force-pushed the eslint_jasmine branch from 2e51817 to 99ee308 Compare January 20, 2024 21:10

timvandermeij approved these changes Jan 21, 2024

View reviewed changes

Snuffleupagus approved these changes Jan 21, 2024

View reviewed changes

calixteman merged commit 10eef37 into mozilla:master Jan 21, 2024
7 checks passed

calixteman deleted the eslint_jasmine branch January 21, 2024 15:36

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Avoid to have focused tests in using eslint-plugin-jasmine #17548

Avoid to have focused tests in using eslint-plugin-jasmine #17548

calixteman commented Jan 20, 2024

timvandermeij left a comment •

edited

Loading

Avoid to have focused tests in using eslint-plugin-jasmine #17548

Avoid to have focused tests in using eslint-plugin-jasmine #17548

Conversation

calixteman commented Jan 20, 2024

timvandermeij left a comment • edited Loading

Choose a reason for hiding this comment

timvandermeij left a comment •

edited

Loading