-
Notifications
You must be signed in to change notification settings - Fork 10k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-enable the should compress and save text
unit-test (issue 17399)
#17591
Conversation
09dd28e
to
04e5c64
Compare
04e5c64
to
d9a242a
Compare
This unit-test is now failing in up to date versions of Node.js respectively Chromium-browsers, since `CompressionStream` no longer produces consistent data across all environments/browsers. However logging the compressed TypedArray produced by `writeStream`, with Firefox respectively Chrome, and then feeding *both* of those TypedArray as input to `DecompressionStream` produced the same (correct) result in both browsers. Hence the *exact* output of `CompressionStream` shouldn't matter, as long as we're able to successfully decompress it when the resulting PDF document is opened with the PDF.js library, and the unit-test is thus extended to check this.
d9a242a
to
3842912
Compare
/botio unittest |
From: Bot.io (Linux m4)ReceivedCommand cmd_unittest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/34d409c52703780/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_unittest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/0a8cd6c69b5843f/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/34d409c52703780/output.txt Total script time: 2.33 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/0a8cd6c69b5843f/output.txt Total script time: 8.16 mins
|
Looks good; thank you for doing this so we can enable this test again! |
This unit-test is now failing in up to date versions of Node.js respectively Chromium-browsers, since
CompressionStream
no longer produces consistent data across all environments/browsers.However logging the compressed TypedArray produced by
writeStream
, with Firefox respectively Chrome, and then feeding both of those TypedArray as input toDecompressionStream
produced the same (correct) result in both browsers.Hence the exact output of
CompressionStream
shouldn't matter, as long as we're able to successfully decompress it when the resulting PDF document is opened with the PDF.js library, and the unit-test is thus extended to check this.