Remove most waitForTimeout usage from the freetext editor integration tests
#18041
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timvandermeij
commented
May 2, 2024
timvandermeij
commented
May 2, 2024
|
/botio integrationtest |
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @timvandermeij received. Current queue size: 0 Live output at: http://54.193.163.58:8877/0a1f10fb0fb77d8/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @timvandermeij received. Current queue size: 0 Live output at: http://54.241.84.105:8877/32468a9cce24e6e/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/32468a9cce24e6e/output.txt Total script time: 7.25 mins
|
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/0a1f10fb0fb77d8/output.txt Total script time: 21.14 mins
|
|
The Windows failure above is already tracked in #17931 and therefore unrelated to this PR. |
…on tests This commit replaces a `waitForTimeout` occurrence with an equivalent `waitForSelector` expression, and removes two other `waitForTimeout` occurrences that are obsolete because we already wait for an observable event to trigger or class change to happen. Note that the other `waitForTimeout` occurrences in this file are either part of mozilla#17931 or remain until we find a good way to ensure that nothing happened (because currently there is nothing we can await there).
This commit replaces `waitForFunction` calls that use `document.activeElement` to wait for an element to get focus by simpler `waitForSelector` expressions that use the `:focus` selector. Note that we already use this in other tests, so this improves consistency too.
timvandermeij
force-pushed
the
integration-tests-timeout-freetext
branch
from
8f1a84e
to
bb74338
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The commit messages contain more details about the individual changes.
Fixes a part of #17656.