Remove the rimraf dependency in favor of the built-in Node.js fs.rmSync
#18106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mSync` In Node.js 14.14.0 the `fs.rmSync` function was added that removes files and directories. The `recursive` option is used to remove directories and their contents, making it a drop-in replacement for the `rimraf` dependency we use. Given that PDF.js now requires Node.js 18+ we can be sure that this option is available, so we can safely remove `rimraf` and reduce the number of project dependencies. Co-authored-by: Wojciech Maj <kontakt@wojtekmaj.pl>
timvandermeij
commented
May 16, 2024
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 0 Live output at: http://54.241.84.105:8877/4531430de428dbc/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/4531430de428dbc/output.txt Total script time: 1.18 mins Published |
|
/botio unittest |
From: Bot.io (Windows)ReceivedCommand cmd_unittest from @timvandermeij received. Current queue size: 0 Live output at: http://54.193.163.58:8877/766a874389a3110/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_unittest from @timvandermeij received. Current queue size: 0 Live output at: http://54.241.84.105:8877/cbc3f4e7bdee982/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/cbc3f4e7bdee982/output.txt Total script time: 2.57 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/766a874389a3110/output.txt Total script time: 11.50 mins
|
Snuffleupagus
approved these changes
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Node.js 14.14.0 the
fs.rmSyncfunction was added that removes files and directories. Therecursiveoption is used to remove directories and their contents, making it a drop-in replacement for therimrafdependency we use.Given that PDF.js now requires Node.js 18+ we can be sure that this option is available, so we can safely remove
rimrafand reduce the number of project dependencies.Fixes #16337.
Thanks to @wojtekmaj, obviously credited as co-author of the commit, for providing the original implementation in #17696! For this patch, similar to what we did for the previous part in #17938, I have extracted the
rimraf-only parts of that PR, with some changes to make sure that all Gulp targets work exactly as before, and tested all affected Gulp targets (usingdiff -ron the old/new build directories to recursively diff the contents of all directories and files) to make sure the output before/after this patch is identical.