[api-minor] Remove the setTextContentSource method in TextLayerBuilder (PR 18104 follow-up)
#18170
Conversation
…lder` (PR 18104 follow-up) The `setTextContentSource` functionality is very old code, and was introduced years ago together with streaming of textContent. By moving the `streamTextContent`-call into the `TextLayerBuilder` class we collect more functionality in one place and slightly reduce the amount of code needed.
…rrendered" events Currently we repeat virtually the same, with the exception of the name, event dispatching code four times for the different viewer layers.
|
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/8d9dd7fad116b43/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/4ed490f72cd1bd3/output.txt |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/4ed490f72cd1bd3/output.txt Total script time: 4.31 mins |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/8d9dd7fad116b43/output.txt Total script time: 27.75 mins
Image differences available at: http://54.241.84.105:8877/8d9dd7fad116b43/reftest-analyzer.html#web=eq.log |
|
/botio-windows test |
From: Bot.io (Windows)ReceivedCommand cmd_test from @timvandermeij received. Current queue size: 0 Live output at: http://54.193.163.58:8877/5d59e35b829d95a/output.txt |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/5d59e35b829d95a/output.txt Total script time: 42.34 mins
Image differences available at: http://54.193.163.58:8877/5d59e35b829d95a/reftest-analyzer.html#web=eq.log |
|
Thanks! |
[api-minor] Remove the
setTextContentSourcemethod inTextLayerBuilder(PR 18104 follow-up)The
setTextContentSourcefunctionality is very old code, and was introduced years ago together with streaming of textContent.By moving the
streamTextContent-call into theTextLayerBuilderclass we collect more functionality in one place and slightly reduce the amount of code needed.Introduce a helper method, in
PDFPageView, for dispatching "...layerrendered" eventsCurrently we repeat virtually the same, with the exception of the name, event dispatching code four times for the different viewer layers.