Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't register a pending TextLayer until render is invoked (PR 18104 follow-up) #18171

Merged
merged 1 commit into from
May 28, 2024
Merged

Don't register a pending TextLayer until render is invoked (PR 18104 follow-up) #18171

merged 1 commit into from
May 28, 2024

Commits on May 26, 2024

  1. Don't register a pending TextLayer until render is invoked (PR 18… 

    …104 follow-up)

After the re-factoring in PR 18104 there's now a *theoretical* risk that a pending `TextLayer` is never removed, which we can avoid by not registering it until `render` is invoked.
Note that this doesn't affect the viewer or tests, but if a third-party user calls `new TextLayer(...)` without a following call of either the `render`- or `cancel`-method we'd block global clean-up without this patch.
    @Snuffleupagus
    Snuffleupagus committed May 26, 2024
    Configuration menu
    Copy the full SHA
    f2e7eee View commit details
    Browse the repository at this point in the history