Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't ignore errors in the Jasmine suite start/end stages #18321

Merged

Commits on Jun 23, 2024

  1. Don't ignore errors in the Jasmine suite start/end stages

    Currently errors in `afterAll` are logged, but don't fail the tests.
    This could cause new errors during test teardown to go by unnoticed.
    
    Moreover, the integration test use a different reporting mechanism which
    also handled errors differently (this is extra reason to do mozilla#12730).
    
    This patch fixes the issues by consistently handling errors in
    `suiteStarted` and `suiteDone` in both reporting mechanisms.
    
    Fixes mozilla#18319.
    timvandermeij committed Jun 23, 2024
    Configuration menu
    Copy the full SHA
    2f3bf6f View commit details
    Browse the repository at this point in the history