Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Also update the width/unicode data when replacing missing glyphs in non-embedded Type1 fonts (issue 18059) #18412

Merged
merged 3 commits into from
Jul 11, 2024
Merged

Also update the width/unicode data when replacing missing glyphs in non-embedded Type1 fonts (issue 18059) #18412

merged 3 commits into from
Jul 11, 2024

Conversation

Snuffleupagus
Copy link
Collaborator

Please note: This causes a little bit of movement in the issue2770 test-case, however this matches the rendering in both Adobe Reader and PDFium.

@Snuffleupagus
Extend test-coverage for non-embedded Type1 fonts where .notdef glyph…
7ffa9a2 
…s are replaced with spaces
@Snuffleupagus
Revert "Remove the unused Font.prototype.spaceWidth getter (PR 1342…
f9d6320 
…4 follow-up)"

This reverts commit 4aee672.
@Snuffleupagus
Also update the width/unicode data when replacing missing glyphs in n…
56653e5 
…on-embedded Type1 fonts (issue 18059)

*Please note:* This causes a little bit of movement in the `issue2770` test-case, however this matches the rendering in both Adobe Reader and PDFium.
@Snuffleupagus Snuffleupagus linked an issue Jul 9, 2024 that may be closed by this pull request
No spacing between characters #18059
Closed
@Snuffleupagus
Copy link
Collaborator Author

/botio test

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/2cf766d37589da7/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.193.163.58:8877/1b583aabd155d62/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/2cf766d37589da7/output.txt

Total script time: 30.60 mins

  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: FAILED
  different ref/snapshot: 353
  different first/second rendering: 1

Image differences available at: http://54.241.84.105:8877/2cf766d37589da7/reftest-analyzer.html#web=eq.log

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/1b583aabd155d62/output.txt

Total script time: 44.31 mins

  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: FAILED
  different ref/snapshot: 334

Image differences available at: http://54.193.163.58:8877/1b583aabd155d62/reftest-analyzer.html#web=eq.log

@Snuffleupagus
Copy link
Collaborator Author

/botio browsertest

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Received

Command cmd_browsertest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.193.163.58:8877/6aae572880258fc/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_browsertest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/401523fc3ed612a/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/401523fc3ed612a/output.txt

Total script time: 20.14 mins

  • Regression tests: FAILED
  different ref/snapshot: 18
  different first/second rendering: 1

Image differences available at: http://54.241.84.105:8877/401523fc3ed612a/reftest-analyzer.html#web=eq.log

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/6aae572880258fc/output.txt

Total script time: 24.97 mins

  • Regression tests: FAILED
  different ref/snapshot: 2

Image differences available at: http://54.193.163.58:8877/6aae572880258fc/reftest-analyzer.html#web=eq.log

@Snuffleupagus
Copy link
Collaborator Author

@calixteman Gentle review ping?

calixteman
calixteman approved these changes Jul 11, 2024
View reviewed changes
Copy link
Contributor

@calixteman calixteman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you.

@Snuffleupagus Snuffleupagus merged commit e8d35c2 into mozilla:master Jul 11, 2024
9 checks passed
@Snuffleupagus
Copy link
Collaborator Author

/botio makeref

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Received

Command cmd_makeref from @Snuffleupagus received. Current queue size: 1

Live output at: http://54.193.163.58:8877/ef07d3cda758a93/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_makeref from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/0d03f099a4d5d80/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/0d03f099a4d5d80/output.txt

Total script time: 20.18 mins

  • Make references: Passed
  • Check references: Passed

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Success

Full output at http://54.193.163.58:8877/ef07d3cda758a93/output.txt

Total script time: 24.72 mins

  • Make references: Passed
  • Check references: Passed

@Snuffleupagus Snuffleupagus deleted the issue-18059 branch July 11, 2024 09:28
@npanchal108 npanchal108 mentioned this pull request Aug 31, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calixteman calixteman calixteman approved these changes

Assignees
No one assigned
Labels
font-conversion font-type1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

No spacing between characters
3 participants
@Snuffleupagus @moz-tools-bot @calixteman