Add more validation when setting AppOptions (PR 18413 follow-up)
#18450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After the changes in PR 18413 we're now relying even more on `AppOptions` and it thus seems like a good idea to ensure that no invalid values can be added.
Hence the `AppOptions.{set, setAll}` methods will now *unconditionally* validate that the type of the values agree with the default-options.
Snuffleupagus
force-pushed
the
AppOptions-set-validation
branch
from
5c7b47c
to
216d3a9
Compare
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/e20148a54001f79/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/dfe6df0e9de9412/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/e20148a54001f79/output.txt Total script time: 8.56 mins
|
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/dfe6df0e9de9412/output.txt Total script time: 18.54 mins
|
timvandermeij
approved these changes
Jul 20, 2024
|
This sounds like a good idea to me; thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After the changes in PR #18413 we're now relying even more on
AppOptionsand it thus seems like a good idea to ensure that no invalid values can be added.Hence the
AppOptions.{set, setAll}methods will now unconditionally validate that the type of the values agree with the default-options.