Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Load the image-to-text model when opening the pdf viewer in Firefox (bug 1908938) #18461

Merged
merged 1 commit into from
Jul 19, 2024
Merged

Load the image-to-text model when opening the pdf viewer in Firefox (bug 1908938) #18461

merged 1 commit into from
Jul 19, 2024

Conversation

calixteman
Copy link
Contributor

No description provided.

@calixteman
Copy link
Contributor Author

/botio integrationtest

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/3fbcf00d0faecbf/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/cccd29d1135bad7/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/3fbcf00d0faecbf/output.txt

Total script time: 8.77 mins

  • Integration Tests: Passed

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Success

Full output at http://54.193.163.58:8877/cccd29d1135bad7/output.txt

Total script time: 18.61 mins

  • Integration Tests: Passed

Snuffleupagus
Snuffleupagus reviewed Jul 19, 2024
View reviewed changes
web/app.js Outdated Show resolved Hide resolved
web/firefoxcom.js Outdated Show resolved Hide resolved
web/firefoxcom.js Outdated Show resolved Hide resolved
Snuffleupagus
Snuffleupagus reviewed Jul 19, 2024
View reviewed changes
web/firefoxcom.js Outdated Show resolved Hide resolved
@calixteman calixteman force-pushed the bug1908938 branch 2 times, most recently from 2fde29b to c9fb206 Compare July 19, 2024 18:55
Snuffleupagus
Snuffleupagus reviewed Jul 19, 2024
View reviewed changes
web/firefoxcom.js Outdated Show resolved Hide resolved
web/firefoxcom.js Outdated Show resolved Hide resolved
web/firefoxcom.js Show resolved Hide resolved
Snuffleupagus
Snuffleupagus approved these changes Jul 19, 2024
View reviewed changes
Copy link
Collaborator

@Snuffleupagus Snuffleupagus left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The #loadAltTextEngine-method feels easier to understand after the last round of changes.

r=me, thank you!

@calixteman
Copy link
Contributor Author

/botio integrationtest

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/d7852b745dfe46f/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/fed3a1a682b20fc/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/d7852b745dfe46f/output.txt

Total script time: 8.55 mins

  • Integration Tests: Passed

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/fed3a1a682b20fc/output.txt

Total script time: 18.38 mins

  • Integration Tests: FAILED

@calixteman calixteman merged commit ed83d7c into mozilla:master Jul 19, 2024
9 checks passed
@calixteman calixteman deleted the bug1908938 branch July 19, 2024 21:08
@npanchal108 npanchal108 mentioned this pull request Aug 31, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Snuffleupagus Snuffleupagus Snuffleupagus approved these changes

Assignees
No one assigned
Labels
editor firefox-specific
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@calixteman @moz-tools-bot @Snuffleupagus