[Editor] Allow Float32Array for quadpoints in annotations (bug 1907958) #18526
Conversation
|
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @calixteman received. Current queue size: 0 Live output at: http://54.241.84.105:8877/60b5d7476401114/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @calixteman received. Current queue size: 0 Live output at: http://54.193.163.58:8877/46053aafd269bc9/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/60b5d7476401114/output.txt Total script time: 30.02 mins
Image differences available at: http://54.241.84.105:8877/60b5d7476401114/reftest-analyzer.html#web=eq.log |
Added annotations could have some quadpoints (highlight, ink). The isNumberArray check was returning false and consequently the annotation wasn't printable. The tests didn't catch this issue because the quadpoints were passed as Array. So driver.js has been updated in order to pass them as Float32Array in order to be in a situation similar to the real life one.
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/46053aafd269bc9/output.txt Total script time: 44.22 mins
Image differences available at: http://54.193.163.58:8877/46053aafd269bc9/reftest-analyzer.html#web=eq.log |
|
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @calixteman received. Current queue size: 0 Live output at: http://54.241.84.105:8877/51bccbf9f9b5b07/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @calixteman received. Current queue size: 0 Live output at: http://54.193.163.58:8877/3a001d62419c822/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/51bccbf9f9b5b07/output.txt Total script time: 30.16 mins
Image differences available at: http://54.241.84.105:8877/51bccbf9f9b5b07/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/3a001d62419c822/output.txt Total script time: 45.37 mins
Image differences available at: http://54.193.163.58:8877/3a001d62419c822/reftest-analyzer.html#web=eq.log |
Added annotations could have some quadpoints (highlight, ink). The isNumberArray check was returning false and consequently the annotation wasn't printable.
The tests didn't catch this issue because the quadpoints were passed as Array.
So driver.js has been updated in order to pass them as Float32Array in order to be in a situation similar to the real life one.