Avoid to have a white line around the canvas #18698

calixteman · 2024-09-05T15:06:12Z

No description provided.

calixteman · 2024-09-05T15:06:27Z

/botio-linux preview

moz-tools-bot · 2024-09-05T15:06:30Z

From: Bot.io (Linux m4)

Received

Command cmd_preview from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/88217b30ad42bab/output.txt

moz-tools-bot · 2024-09-05T15:07:31Z

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/88217b30ad42bab/output.txt

Total script time: 1.01 mins

Published

Viewer: http://54.241.84.105:8877/88217b30ad42bab/web/viewer.html
Viewer (legacy): http://54.241.84.105:8877/88217b30ad42bab/legacy/web/viewer.html

web/pdf_page_view.js

nicolo-ribaudo · 2024-09-05T15:53:38Z

This looks good to me, does it also still fix the "small movement when the canvas is redrawing" problem you mentioned?

calixteman · 2024-09-05T15:54:39Z

This looks good to me, does it also still fix the "small movement when the canvas is redrawing" problem you mentioned?

Yes it does for me, doesn't it for you ?

Snuffleupagus · 2024-09-05T16:12:18Z

Comparing https://mozilla.github.io/pdf.js/web/viewer.html and #18698 (comment) side-by-side, it does appear that this patch makes the canvas slightly blurry at some zoom levels (e.g. auto).

calixteman · 2024-09-05T16:16:21Z

/botio-linux preview

moz-tools-bot · 2024-09-05T16:16:24Z

From: Bot.io (Linux m4)

Received

Command cmd_preview from @calixteman received. Current queue size: 1

Live output at: http://54.241.84.105:8877/9d05db1bb764359/output.txt

moz-tools-bot · 2024-09-05T16:32:01Z

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/9d05db1bb764359/output.txt

Total script time: 1.01 mins

Published

Viewer: http://54.241.84.105:8877/9d05db1bb764359/web/viewer.html
Viewer (legacy): http://54.241.84.105:8877/9d05db1bb764359/legacy/web/viewer.html

Snuffleupagus · 2024-09-05T17:01:27Z

The new preview still suffers from blurriness issues unfortunately; there doesn't seem to be any improvement there.

Are the src/display/display_utils.js changes perhaps enough to fix the regression as filed, because if so I believe that we should do that first and worry about the other parts of this PR later!?

calixteman · 2024-09-05T17:50:12Z

The new preview still suffers from blurriness issues unfortunately; there doesn't seem to be any improvement there.

Are the src/display/display_utils.js changes perhaps enough to fix the regression as filed, because if so I believe that we should do that first and worry about the other parts of this PR later!?

Unfortunately it isn't enough.
At 70%, the page dims are 555x785 when the canvas css dims are 554x784.

I can see some blurriness on a screen with window.devicePixelRatio === 1.5 too but only around a zoom level equals to 60-70% when the text becomes barely readable (at least for me). In changing in the css width & height to calc(100% - 1px), I can see an improvement but then we see the page background.
I tried the same with a screen where the ratio is 1 and there aren't that much differences.
I've the impress that the problem mainly something about font hinting and anti-aliasing.
Out of curiosity, I added image-rendering: pixelated; to the canvas style and it fixes the blurriness for me.

That said my feeling is that the patch by itself isn't really the problem but there's maybe something else on the gfx side.
I'll check how it behaves in Chrome later.

Snuffleupagus · 2024-09-05T17:56:41Z

I just realized that I wasn't clear before: The blurriness I'm talking about with this patch is with the default tracemonkey.pdf file and window.devicePixelRatio === 2, at e.g. the "auto" zoom level.
Hence this patch really doesn't seem acceptable as-is, most unfortunately.

calixteman · 2024-09-05T18:53:34Z

I think it's because the ratio between the canvas width/height and the canvas css width/height is no more exactly equal to 1.5 (my devicePixelRatio).
So I think, we should change the 3rd parameter of the round function in the css to have something which uses the denominator found by Farey approximation.
That said maybe having the right ratio helped to just use the right algorithm to downscale the canvas, so maybe (too much maybe in this sentence) using pixelated could be the right way to do it.

calixteman · 2024-09-05T19:21:26Z

@Snuffleupagus, what's the real zoom level, as a number, you use ?

Snuffleupagus · 2024-09-05T20:29:10Z

what's the real zoom level, as a number, you use ?

125 percent; as defined in

pdf.js/web/ui_utils.js

Line 22 in 77c7ec6

const MAX_AUTO_SCALE = 1.25;

calixteman · 2024-09-06T13:59:03Z

/botio-linux preview

moz-tools-bot · 2024-09-06T13:59:05Z

From: Bot.io (Linux m4)

Received

Command cmd_preview from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/1a16f65dd7ba6b1/output.txt

moz-tools-bot · 2024-09-06T14:00:06Z

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/1a16f65dd7ba6b1/output.txt

Total script time: 1.01 mins

Published

Viewer: http://54.241.84.105:8877/1a16f65dd7ba6b1/web/viewer.html
Viewer (legacy): http://54.241.84.105:8877/1a16f65dd7ba6b1/legacy/web/viewer.html

Snuffleupagus · 2024-09-06T14:12:27Z

Testing with the tracemonkey.pdf file, this patch unfortunately still looks worse (for me) compared to master.

calixteman · 2024-09-06T14:17:17Z

What do you mean exactly by worse ?
Could you share a screenshot showing both rendering ?

Snuffleupagus · 2024-09-06T14:43:53Z

Here's two screen-shots, from master respectively the patch, where the letters are noticeably more blurry with this patch. (Comparing the images at high magnification might be helpful to see the differences more clearly.)

nicolo-ribaudo · 2024-09-06T15:50:33Z

The new preview still suffers from blurriness issues unfortunately; there doesn't seem to be any improvement there.
Are the src/display/display_utils.js changes perhaps enough to fix the regression as filed, because if so I believe that we should do that first and worry about the other parts of this PR later!?

Unfortunately it isn't enough. At 70%, the page dims are 555x785 when the canvas css dims are 554x784.

Is this with the test PDF? I'm seeing both as 555x785 🤔 (by using inspect element and changing those round() CSS functions at https://mozilla.github.io/pdf.js/web/viewer.html, with Firefox 130.0)

calixteman · 2024-09-06T19:03:58Z

@Snuffleupagus, it's because Firefox is using float32 numbers when evaluating a calc expression in the css.
But Chrome and Safari seem to use some float64.
/botio-linux preview

moz-tools-bot · 2024-09-06T19:04:01Z

From: Bot.io (Linux m4)

Received

Command cmd_preview from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/ab979362296cb40/output.txt

moz-tools-bot · 2024-09-06T19:05:02Z

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/ab979362296cb40/output.txt

Total script time: 1.01 mins

Published

Viewer: http://54.241.84.105:8877/ab979362296cb40/web/viewer.html
Viewer (legacy): http://54.241.84.105:8877/ab979362296cb40/legacy/web/viewer.html

Snuffleupagus

This seems to work much better now.

src/display/display_utils.js

test/unit/ui_utils_spec.js

web/pdf_page_view.js

web/ui_utils.js

calixteman · 2024-09-07T12:56:54Z

Having a more or less thin white line on some page sides is a longstanding bug... Thanks to mozregression, I managed to get that the regressor is:
#6552
That said, nowadays the thin line is a bit too much thick.

calixteman · 2024-09-07T14:51:05Z

I added an integration test to avoid any future regression.

Snuffleupagus

r=me, with a few more comments and passing tests; thank you!

test/integration/viewer_spec.mjs

The canvas must have the same dims as the page in order to avoid to see the page background.

calixteman · 2024-09-07T18:13:41Z

FYI, the added integration test is correctly failing on master.

calixteman · 2024-09-07T18:13:49Z

/botio test

moz-tools-bot · 2024-09-07T18:13:51Z

From: Bot.io (Linux m4)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/6593269a41bf21a/output.txt

moz-tools-bot · 2024-09-07T18:13:51Z

From: Bot.io (Windows)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/2d76cd3c497b2ab/output.txt

moz-tools-bot · 2024-09-07T18:44:45Z

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/6593269a41bf21a/output.txt

Total script time: 30.89 mins

Unit tests: Passed
Integration Tests: Passed
Regression tests: FAILED

  different ref/snapshot: 163

Image differences available at: http://54.241.84.105:8877/6593269a41bf21a/reftest-analyzer.html#web=eq.log

calixteman · 2024-09-07T18:53:04Z

The small movements we've are very likely due to the change in the text (or annotation) layer dimensions where we now round differently (in passing --scale-round-x/y as third parameter).

moz-tools-bot · 2024-09-07T18:59:53Z

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/2d76cd3c497b2ab/output.txt

Total script time: 46.01 mins

Unit tests: Passed
Integration Tests: FAILED
Regression tests: FAILED

  different ref/snapshot: 77

Image differences available at: http://54.193.163.58:8877/2d76cd3c497b2ab/reftest-analyzer.html#web=eq.log

calixteman · 2024-09-07T20:22:29Z

/botio makeref

moz-tools-bot · 2024-09-07T20:22:31Z

From: Bot.io (Linux m4)

Received

Command cmd_makeref from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/5d01090de0eacc4/output.txt

moz-tools-bot · 2024-09-07T20:22:31Z

From: Bot.io (Windows)

Received

Command cmd_makeref from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/1788070cff34fc7/output.txt

moz-tools-bot · 2024-09-07T20:42:48Z

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/5d01090de0eacc4/output.txt

Total script time: 20.28 mins

Make references: Passed
Check references: Passed

moz-tools-bot · 2024-09-07T20:49:04Z

From: Bot.io (Windows)

Success

Full output at http://54.193.163.58:8877/1788070cff34fc7/output.txt

Total script time: 26.54 mins

Make references: Passed
Check references: Passed

calixteman mentioned this pull request Sep 5, 2024

[Bug]: White border in viewer for PDFs with background color #18694

Closed

Snuffleupagus reviewed Sep 5, 2024

View reviewed changes

web/pdf_page_view.js Outdated Show resolved Hide resolved

web/pdf_page_view.js Outdated Show resolved Hide resolved

calixteman force-pushed the issue18694 branch from ec8cc8f to d48d0a2 Compare September 5, 2024 15:43

calixteman force-pushed the issue18694 branch from d48d0a2 to d641dc5 Compare September 6, 2024 13:56

calixteman marked this pull request as ready for review September 6, 2024 13:56

timvandermeij added the viewer label Sep 6, 2024

timvandermeij linked an issue Sep 6, 2024 that may be closed by this pull request

[Bug]: White border in viewer for PDFs with background color #18694

Closed

calixteman force-pushed the issue18694 branch from d641dc5 to 0c5a919 Compare September 6, 2024 19:03

nicolo-ribaudo mentioned this pull request Sep 6, 2024

[css-values-4] Which IEEE-754 semantics do math functions follow? w3c/csswg-drafts#10849

Closed

Snuffleupagus reviewed Sep 7, 2024

View reviewed changes

calixteman force-pushed the issue18694 branch 2 times, most recently from 9085d35 to 2d2570f Compare September 7, 2024 14:50

Snuffleupagus approved these changes Sep 7, 2024

View reviewed changes

test/integration/viewer_spec.mjs Outdated Show resolved Hide resolved

test/integration/viewer_spec.mjs Outdated Show resolved Hide resolved

Avoid to have a white line around the canvas

68332ec

The canvas must have the same dims as the page in order to avoid to see the page background.

calixteman force-pushed the issue18694 branch from 2d2570f to 68332ec Compare September 7, 2024 18:12

calixteman merged commit 5369a24 into mozilla:master Sep 7, 2024
8 checks passed

calixteman mentioned this pull request Sep 9, 2024

[Bug]: An added stamp annotation is resizing itself #18715

Closed

This was referenced Sep 9, 2024

Update dependencies and translations to the most recent versions #18708

Merged

[Editor] Avoid to have a stamp editor resizing itself #18716

Merged

Fix the intermittent integration test failure when an highlight is hovered #18721

Open

timvandermeij mentioned this pull request Sep 22, 2024

Fix the "Select text with the pointer hovering an existing highlight must check that an existing highlight is ignored on hovering" integration test #18775

Open

Avoid to have a white line around the canvas #18698

Avoid to have a white line around the canvas #18698

Conversation

calixteman commented Sep 5, 2024

calixteman commented Sep 5, 2024

moz-tools-bot commented Sep 5, 2024

From: Bot.io (Linux m4)

Received

moz-tools-bot commented Sep 5, 2024

From: Bot.io (Linux m4)

Success

Published

nicolo-ribaudo commented Sep 5, 2024

calixteman commented Sep 5, 2024

Snuffleupagus commented Sep 5, 2024

calixteman commented Sep 5, 2024

moz-tools-bot commented Sep 5, 2024

From: Bot.io (Linux m4)

Received

moz-tools-bot commented Sep 5, 2024

From: Bot.io (Linux m4)

Success

Published

Snuffleupagus commented Sep 5, 2024

calixteman commented Sep 5, 2024

Snuffleupagus commented Sep 5, 2024

calixteman commented Sep 5, 2024

calixteman commented Sep 5, 2024

Snuffleupagus commented Sep 5, 2024

calixteman commented Sep 6, 2024

moz-tools-bot commented Sep 6, 2024

From: Bot.io (Linux m4)

Received

moz-tools-bot commented Sep 6, 2024

From: Bot.io (Linux m4)

Success

Published

Snuffleupagus commented Sep 6, 2024

calixteman commented Sep 6, 2024

Snuffleupagus commented Sep 6, 2024

nicolo-ribaudo commented Sep 6, 2024 • edited Loading

calixteman commented Sep 6, 2024

moz-tools-bot commented Sep 6, 2024

From: Bot.io (Linux m4)

Received

moz-tools-bot commented Sep 6, 2024

From: Bot.io (Linux m4)

Success

Published

Snuffleupagus left a comment

Choose a reason for hiding this comment

calixteman commented Sep 7, 2024

calixteman commented Sep 7, 2024

Snuffleupagus left a comment

Choose a reason for hiding this comment

calixteman commented Sep 7, 2024

calixteman commented Sep 7, 2024

moz-tools-bot commented Sep 7, 2024

From: Bot.io (Linux m4)

Received

moz-tools-bot commented Sep 7, 2024

From: Bot.io (Windows)

Received

moz-tools-bot commented Sep 7, 2024

From: Bot.io (Linux m4)

Failed

calixteman commented Sep 7, 2024

moz-tools-bot commented Sep 7, 2024

From: Bot.io (Windows)

Failed

calixteman commented Sep 7, 2024

moz-tools-bot commented Sep 7, 2024

From: Bot.io (Linux m4)

Received

moz-tools-bot commented Sep 7, 2024

From: Bot.io (Windows)

Received

moz-tools-bot commented Sep 7, 2024

From: Bot.io (Linux m4)

Success

nicolo-ribaudo commented Sep 6, 2024 •

edited

Loading