Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve the promise-caching in the PDFDocument.fieldObjects getter #18871

Merged
merged 2 commits into from
Oct 8, 2024
Merged

Improve the promise-caching in the PDFDocument.fieldObjects getter #18871

merged 2 commits into from
Oct 8, 2024

Commits on Oct 8, 2024

  1. Improve the promise-caching in the PDFDocument.fieldObjects getter 

    After PR 18845 we're accessing this getter more, hence it seems like a good idea to ensure that the initial `formInfo` access is covered as well.
While unlikely to be a problem in practice, at least theoretically that data may not be available and the code in `fieldObjects` could thus currently be *unintentionally* invoked more than once.
    @Snuffleupagus
    Snuffleupagus committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    e3b5ed2 View commit details
    Browse the repository at this point in the history

  2. Reduce duplication in the PDFDocument.calculationOrderIds getter

    @Snuffleupagus
    Snuffleupagus committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    662bd02 View commit details
    Browse the repository at this point in the history