-
Notifications
You must be signed in to change notification settings - Fork 10k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add B2G build and new preprocessor. #1953
Conversation
/botio-windows preview |
From: Bot.io (Linux)ReceivedCommand cmd_lint from @brendandahl received. Current queue size: 0 Live output at: http://107.21.233.14:8877/c531b9fe175854a/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_preview from @brendandahl received. Current queue size: 0 Live output at: http://107.22.172.223:8877/42440e5b0162f67/output.txt |
From: Bot.io (Windows)SuccessFull output at http://107.22.172.223:8877/42440e5b0162f67/output.txt Total script time: 0.83 mins Published |
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/c531b9fe175854a/output.txt Total script time: 1.28 mins
|
As per IRC, @brendandahl will factor out |
@@ -150,6 +151,7 @@ var FirefoxCom = (function FirefoxComClosure() { | |||
} | |||
}; | |||
})(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we comment it or include as a snippet?
Build/pdf.js and build/chrome/content/build/pdf.js still have pre-processor directives. Not really sure how to check B2G output.
+1 from me if notes above will be addressed |
Missed adding the snippet file. For playing with b2g I've been using the desktop builds from: And running the following script:
|
For empty repo,
Other than that works; tested with gaia commit 5e3499c4ad1d |
Add B2G build and new preprocessor.
Since we're adding another target that I believe will require more customization in the future and I think our strategy of just using SED was getting too messy, I've added a new preprocessor which tries to follow the ff preprocessor(https://developer.mozilla.org/en/Build/Text_Preprocessor). I also added another little build helper function to help with common steps we were taking in the main build targets(firefox,chrome,mozcentral,b2g,web). We could probably simplify things even further if we added an initial layout step to this, but the PR was already getting too big so I'll wait to do that.
Also, I added a new build target
generic
which builds the generic production version of pdf.js. This is basically the contents of our oldweb
build target. I mainly did this because now the filebuild/pdf.js
is not preprocessed since it needs to be preprocessed differently by each main build target.For testing, I built all the targets and compared them to the current build output. Everything still needs verification though.