Put mask data to the canvas in small slices. #4355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/botio test |
From: Bot.io (Linux)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://107.21.233.14:8877/40a018a470e8a03/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://107.22.172.223:8877/38fa5c89e8d3a1c/output.txt |
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/40a018a470e8a03/output.txt Total script time: 24.31 mins
|
From: Bot.io (Windows)FailedFull output at http://107.22.172.223:8877/38fa5c89e8d3a1c/output.txt Total script time: 35.88 mins
Image differences available at: http://107.22.172.223:8877/38fa5c89e8d3a1c/reftest-analyzer.html#web=eq.log |
|
The failing Windows test was "ichiji", which also failed in #4354, so I think it's not caused by this patch. |
|
Yep, skip ichiji test result |
yurydelendik
added a commit
that referenced
this pull request
Mar 3, 2014
Put mask data to the canvas in small slices.
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In pull #4138, I changed image drawing to be in small chunks, to avoid creating large copies of the image data.
This patch does the same thing for image masks. I have two test documents that use masks, which I test by scrolling through the whole document and measuring peak RSS. The improvements were: