[Firefox] Enable linting of *.jsm files and update the code style in extensions/firefox/content #5406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@timvandermeij Since you've reviewed other code style patches: I'm wondering if you have the time, and if you feel comfortable enough with this part of the codebase, to review this PR? |
|
/botio-linux preview |
From: Bot.io (Linux)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 0 Live output at: http://107.21.233.14:8877/771c135a1ae1b25/output.txt |
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/771c135a1ae1b25/output.txt Total script time: 0.78 mins Published
|
timvandermeij
added a commit
that referenced
this pull request
Dec 15, 2014
[Firefox] Enable linting of *.jsm files and update the code style in extensions/firefox/content
|
Nice work, thanks! |
|
@timvandermeij Thank you for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default JSHint will only lint
*.jsfiles, however it is possible specify that other file types should be covered as well. To ensure a consistent code style, and to help catch errors, I think that it's a good idea to also include*.jsmfiles when running lint.Besides updating the
node make lintcommand, this PR also makes the necessary adjustments to make linting pass.Besides, obviously, testing this using the built addon, I've also made extensive use of the addon debugger to make sure that changing to strict equalities doesn't change the behaviour.
Note: In a couple of the files I've relaxed the maximum line length requirement, because enforcing 80 characters would have meant adding a, in my opinion, disproportionally large number of new lines. I tried to keep the total diff as small as possible, but I would be happy to change this is if that is preferred.