Add video annotation support #5450

harshavardhana · 2014-10-27T23:27:17Z

This work is still work in progress, doesn't seem to work for http://acroeng.adobe.com/Test_Files/classic_multimedia//VolvoS40V50-Full.pdf

It does seem like it worked in the beginning, but doesn't seem to work for me.

Rebasing change from pull request #4376 to get some reviews and pitfalls.

timvandermeij · 2014-10-28T17:34:00Z

Before we can close #4376 and continue the work on this here, the author of this commit needs to be amended. See https://stackoverflow.com/questions/750172/change-the-author-of-a-commit-in-git/1320317#1320317 on how to do this. @pramodhkp needs to be stated as the author of this commit.

harshavardhana · 2014-10-28T18:13:09Z

Author updated as @pramodhkp

timvandermeij · 2014-10-29T18:49:55Z

Thank you. Fixes #2787.

Rob--W · 2014-11-01T18:12:53Z

src/core/annotation.js

+          param2.value = 'mini';
+          element.appendChild(param2);
+        } else {
+          console.error('Cant play video');


Use warn from src/shared/util.js instead of console.error.

Rob--W · 2014-11-01T18:21:00Z

Could we show a link to download the video when the browser cannot play the video? Then the user can download the file and play it with vlc if they wish. UI TBD.

yurydelendik · 2014-11-01T20:11:57Z

The video sometimes can be found on the attachment tab

Snuffleupagus · 2014-11-02T11:01:23Z

src/core/annotation.js

+
+    function guessContentType(dict) {
+      var extToMime = {
+        'avi' : 'video/avi',


Nit: only use space after the colon, and not before it. This line should read:

'avi': 'video/avi',

The same applies on the next two lines as well.

harshavardhana · 2014-11-02T20:44:00Z

Tested with this example - http://dante.ctan.org/tex-archive/macros/latex/contrib/movie15/doc/overlay-example.pdf

While the plugin and video playing still shows up - if i allow the popups it just crashes chrome on OSX. Will be testing on Linux.

fbender · 2015-11-16T15:11:32Z

@timvandermeij What's blocking merging this PR (except rebasing, ping @harshavardhana )?

timvandermeij · 2015-11-16T21:38:06Z

Nothing big I think. It needs a rebase and testing (unit tests especially).

harshavardhana · 2015-11-26T08:44:32Z

Nothing big I think. It needs a rebase and testing (unit tests especially).

Can you tell me how would i go about adding those unit tests?

Rebased from - https://github.com/pramodhkp/pdf.js/tree/videosupport

…work

humphd · 2015-12-08T20:13:07Z

I was trying your branch, but what's on github doesn't seem to work with that example pdf--the worker dying on

pdf.js/src/core/core.js

Line 276 in 361fa83

var annotationFactory = new AnnotationFactory();

with AnnotationFactory missing. Do you have something locally that fixes this?

timvandermeij · 2015-12-08T21:49:48Z

src/core/annotation.js

-    }
-  }
-};
+var SUPPORTED_TYPES = ['Link', 'Text', 'Widget', 'Screen', 'Movie'];


This change is incorrect. The AnnotationFactory should not be removed (causing the effect that the user above describes), but rather it should be adapted to add a case for Screen and Movie.

humphd · 2015-12-11T22:02:28Z

I played with this some more, and with the Annotation ctor restored in this PR, I can see VideoAnnotations being parsed correctly; however, the getHtmlElementForVideoAnnotation function in annotation_helper.js that should create the video element and usable UI, is never called. I don't know the pdf.js internals enough to fix this, but I assume that the VideoAnnotation needs to somehow indicate that it has backing HTML and viewable content, such that the stuff in pdfPage.getAnnotations() should create and render the element. Looking at how the LinkAnnotation (appears) to do it via data.hasHtml = true;, I wondered if this would be enough, but it isn't; I suspect something has to get parsed out of the annotation's data that isn't currently being done. Any tips?

timvandermeij · 2015-12-12T14:28:55Z

data.hasHtml = true; should render the annotation and it is indeed absent in this PR, which should be changed. I have added some review comments above which might also contribute to the fact that the annotation is not rendered properly.

…review comments

humphd · 2015-12-12T20:15:15Z

I've made all the changes discussed above (the s/InteractiveAnnotation/Annotation/ stuff was already done), still no dice: humphd@635c061. @harshavardhana, I tried to send this to you as a PR, but github is being stupid and doesn't list you in the list of possible forks for pdf.js for some reason, so won't let me. @timvandermeij, what am I missing?

harshavardhana · 2015-12-13T09:27:57Z

I've made all the changes discussed above (the s/InteractiveAnnotation/Annotation/ stuff was already done), still no dice: humphd/pdf.js@635c061. @harshavardhana, I tried to send this to you as a PR, but github is being stupid and doesn't list you in the list of possible forks for pdf.js for some reason, so won't let me. @timvandermeij, what am I missing?

I pulled in your changes and pushed here. Thank you

timvandermeij · 2015-12-13T12:55:24Z

src/core/annotation.js

@@ -14,8 +14,9 @@
 */
 /* globals PDFJS, Util, isDict, isName, stringToPDFString, warn, Dict, Stream,
           stringToBytes, Promise, isArray, ObjectLoader, OperatorList,
-           isValidUrl, OPS, AnnotationType, stringToUTF8String,
-           AnnotationBorderStyleType, ColorSpace, AnnotationFlag, isInt */
+           isValidUrl, OPS, createPromiseCapability, AnnotationType,


The changes for these three lines should also be reverted.

timvandermeij · 2015-12-13T12:58:06Z

/botio-linux preview

pdfjsbot · 2015-12-13T12:58:07Z

From: Bot.io (Linux)

Received

Command cmd_preview from @timvandermeij received. Current queue size: 0

Live output at: http://107.21.233.14:8877/af3f05d4b8ed724/output.txt

pdfjsbot · 2015-12-13T12:58:57Z

From: Bot.io (Linux)

Success

Full output at http://107.21.233.14:8877/af3f05d4b8ed724/output.txt

Total script time: 0.83 mins

Published

timvandermeij · 2015-12-15T15:03:01Z

src/shared/util.js

@@ -45,7 +45,8 @@ var ImageKind = {
 var AnnotationType = {
  WIDGET: 1,
  TEXT: 2,
-  LINK: 3
+  LINK: 3,


Thanks to PR #6757 the changes in this file are no longer necessary as types MOVIE and SCREEN are now already available when you rebase this patch.

fbender · 2016-05-20T21:19:09Z

@harshavardhana Are you still working on this? May you please address the review comments and rebase the branch?

timvandermeij · 2016-09-11T20:42:05Z

Closing as incomplete for the following reasons:

This hasn't been worked on for a long time.
The patch currently does not work for rendering video elements.
There are no tests.
The annotation code has been rewritten, so this needs to be fit into the new framework and therefore this patch is currently not in a mergeable state.

However, we keep the associated issue open and link to this PR from there so that others may use this work as inspiration for a new PR.

harshavardhana changed the title ~~Rebased from - https://github.com/pramodhkp/pdf.js/tree/videosupport~~ Rebased from - pdf.js/tree/videosupport Oct 27, 2014

timvandermeij added annotations 4-work-in-progress labels Oct 28, 2014

harshavardhana force-pushed the pr_out_rebased_from_https_github_com_pramodhkp_pdf_js_tree_videosupport branch from a548890 to 2290bb4 Compare October 28, 2014 18:12

timvandermeij mentioned this pull request Oct 29, 2014

Added video annotation #4376

Closed

harshavardhana force-pushed the pr_out_rebased_from_https_github_com_pramodhkp_pdf_js_tree_videosupport branch from 2290bb4 to 00f5452 Compare October 30, 2014 19:01

harshavardhana changed the title ~~Rebased from - pdf.js/tree/videosupport~~ Add video annotation support Oct 30, 2014

Rob--W reviewed Nov 1, 2014
View reviewed changes

harshavardhana force-pushed the pr_out_rebased_from_https_github_com_pramodhkp_pdf_js_tree_videosupport branch from 19ce390 to ba74b4f Compare November 2, 2014 10:59

Snuffleupagus reviewed Nov 2, 2014
View reviewed changes

harshavardhana force-pushed the pr_out_rebased_from_https_github_com_pramodhkp_pdf_js_tree_videosupport branch 2 times, most recently from 0e29ef9 to c5c5992 Compare November 2, 2014 20:42

harshavardhana force-pushed the pr_out_rebased_from_https_github_com_pramodhkp_pdf_js_tree_videosupport branch from c5c5992 to 84ae57c Compare November 11, 2014 04:06

harshavardhana force-pushed the pr_out_rebased_from_https_github_com_pramodhkp_pdf_js_tree_videosupport branch from 84ae57c to 03686e7 Compare November 20, 2014 07:33

harshavardhana force-pushed the pr_out_rebased_from_https_github_com_pramodhkp_pdf_js_tree_videosupport branch from 03686e7 to 9961b72 Compare January 7, 2015 22:55

fbender mentioned this pull request Nov 16, 2015

Videos in PDF.js #2787

Open

harshavardhana force-pushed the pr_out_rebased_from_https_github_com_pramodhkp_pdf_js_tree_videosupport branch 2 times, most recently from 9667462 to 173f9a6 Compare November 26, 2015 08:28

pramodhkp and others added 4 commits December 8, 2015 15:08

Add video annotation support

03a5d4c

Rebased from - https://github.com/pramodhkp/pdf.js/tree/videosupport

Use warn() instead of console.error()

ec5549c

Cleanup older code, write in accordance with present Annotation frame…

77ddcef

…work

Remove InteractiveAnnotation, use Annotation instead

596fdd1

timvandermeij reviewed Dec 8, 2015
View reviewed changes

Restore AnnotationFactory, add data.hasHtml for VideoAnnotation, fix …

635c061

…review comments

harshavardhana force-pushed the pr_out_rebased_from_https_github_com_pramodhkp_pdf_js_tree_videosupport branch from 4b52236 to 635c061 Compare December 13, 2015 09:23

timvandermeij reviewed Dec 13, 2015
View reviewed changes

timvandermeij reviewed Dec 15, 2015
View reviewed changes

timvandermeij closed this Sep 11, 2016

harshavardhana deleted the pr_out_rebased_from_https_github_com_pramodhkp_pdf_js_tree_videosupport branch September 11, 2016 20:59

awehrfritz mentioned this pull request Jun 6, 2024

Add support for videos typst/typst#955

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add video annotation support #5450

Add video annotation support #5450

harshavardhana commented Oct 27, 2014

timvandermeij commented Oct 28, 2014

harshavardhana commented Oct 28, 2014

timvandermeij commented Oct 29, 2014

Rob--W Nov 1, 2014

harshavardhana Nov 1, 2014

Rob--W commented Nov 1, 2014

yurydelendik commented Nov 1, 2014

Snuffleupagus Nov 2, 2014

harshavardhana commented Nov 2, 2014

fbender commented Nov 16, 2015

timvandermeij commented Nov 16, 2015

harshavardhana commented Nov 26, 2015

humphd commented Dec 8, 2015

timvandermeij Dec 8, 2015

humphd commented Dec 11, 2015

timvandermeij commented Dec 12, 2015

humphd commented Dec 12, 2015

harshavardhana commented Dec 13, 2015

timvandermeij Dec 13, 2015

timvandermeij commented Dec 13, 2015

pdfjsbot commented Dec 13, 2015

pdfjsbot commented Dec 13, 2015

timvandermeij Dec 15, 2015

fbender commented May 20, 2016

timvandermeij commented Sep 11, 2016 •

edited

Loading

Add video annotation support #5450

Add video annotation support #5450

Conversation

harshavardhana commented Oct 27, 2014

timvandermeij commented Oct 28, 2014

harshavardhana commented Oct 28, 2014

timvandermeij commented Oct 29, 2014

Rob--W Nov 1, 2014

Choose a reason for hiding this comment

harshavardhana Nov 1, 2014

Choose a reason for hiding this comment

Rob--W commented Nov 1, 2014

yurydelendik commented Nov 1, 2014

Snuffleupagus Nov 2, 2014

Choose a reason for hiding this comment

harshavardhana commented Nov 2, 2014

fbender commented Nov 16, 2015

timvandermeij commented Nov 16, 2015

harshavardhana commented Nov 26, 2015

humphd commented Dec 8, 2015

timvandermeij Dec 8, 2015

Choose a reason for hiding this comment

humphd commented Dec 11, 2015

timvandermeij commented Dec 12, 2015

humphd commented Dec 12, 2015

harshavardhana commented Dec 13, 2015

timvandermeij Dec 13, 2015

Choose a reason for hiding this comment

timvandermeij commented Dec 13, 2015

pdfjsbot commented Dec 13, 2015

From: Bot.io (Linux)

Received

pdfjsbot commented Dec 13, 2015

From: Bot.io (Linux)

Success

Published

timvandermeij Dec 15, 2015

Choose a reason for hiding this comment

fbender commented May 20, 2016

timvandermeij commented Sep 11, 2016 • edited Loading

timvandermeij commented Sep 11, 2016 •

edited

Loading