fix handling of flags 1-3 in coons shading #6304
Conversation
| "file": "pdfs/coons-allflags-withfunction.pdf", | ||
| "md5": "c5f79c24bf9eb66698be0e4ecaa1bdf8", | ||
| "rounds": 1, | ||
| "type": "eq", |
There was a problem hiding this comment.
nit: extra comma (bad in JSON)
There was a problem hiding this comment.
Also the indenting is a bit off. Compare with the ones below.
There was a problem hiding this comment.
huh? shows identical in my editor
There was a problem hiding this comment.
ah. lol. perhaps i copied the only other bad one in this file :)
There was a problem hiding this comment.
actually the whole file is an indentation mess
There was a problem hiding this comment.
You're right. Keep it like https://github.com/CodingFabian/pdf.js/blob/fixup-6303/test/test_manifest.json#L2331-L2336 for this PR as that is what we always use.
There was a problem hiding this comment.
i can fixup the indention in this file, but which one is the wanted one. give me a reference test case and ill do it now
There was a problem hiding this comment.
We should do that in a different PR. I actually do not like them all myself, and I would prefer:
[
{
"id": "foo",
"name": "bar"
}
]
which is also how JSONLint formats it (and a lot of other projects). But for this PR the current commit is fine!
Short story: somebody got lost in two different indices. pi is an index in the stream and is explained on page 198 of the 32000-spec (however 1-based there), and ps is an index to something in PDF.js. I used the code from flag 0 (which works) to understand which is which. It is also important to understand that for flags 1,2 and 3, the stream is always assigned to the same coordinates and colors. What changes is which "old" coordinates and colors are assigned to what is "missing" in the stream. This is why for these flags, the code is identical except for the assignments in the first "row".
CodingFabian
force-pushed
the
fixup-6303
branch
from
23d05e8
to
c85fa00
Compare
|
/botio-linux preview |
From: Bot.io (Linux)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 0 Live output at: http://107.21.233.14:8877/8dfb83cba8948b8/output.txt |
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/8dfb83cba8948b8/output.txt Total script time: 0.68 mins Published |
|
/botio test |
From: Bot.io (Windows)ReceivedCommand cmd_test from @timvandermeij received. Current queue size: 0 Live output at: http://107.22.172.223:8877/f0369cfc15252f4/output.txt |
From: Bot.io (Linux)ReceivedCommand cmd_test from @timvandermeij received. Current queue size: 0 Live output at: http://107.21.233.14:8877/19e78e672f8d8de/output.txt |
Now I see what you mean (I had tested my patch on the CIB file, not on the file I created today). This looks like the effect that happens also with the lamp_cairo.pdf file. (I have a patch for type 7, and it works fine for another test file, but not for lamp_cairo.pdf). I have the suspicion that this is related to the effect of "extra stuff" that has been seen with types 4 and 5, see #6294. |
From: Bot.io (Windows)SuccessFull output at http://107.22.172.223:8877/f0369cfc15252f4/output.txt Total script time: 18.37 mins
|
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/19e78e672f8d8de/output.txt Total script time: 18.97 mins
|
fix handling of flags 1-3 in coons shading
|
Thank you for the patch. /botio makeref |
From: Bot.io (Linux)ReceivedCommand cmd_makeref from @yurydelendik received. Current queue size: 0 Live output at: http://107.21.233.14:8877/1cbe59bb183f311/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_makeref from @yurydelendik received. Current queue size: 0 Live output at: http://107.22.172.223:8877/471718ec3d85828/output.txt |
From: Bot.io (Windows)SuccessFull output at http://107.22.172.223:8877/471718ec3d85828/output.txt Total script time: 18.55 mins
|
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/1cbe59bb183f311/output.txt Total script time: 18.76 mins
|
pi is an index in the stream and is explained on page 201 of the 32000-spec (however 1-based there), and ps is an index to something in PDF.js. I used the code from flag 0 (which works) to understand which is which. It is also important to understand that for flags 1,2 and 3, the stream is always assigned to the same coordinates and colors. What changes is which "old" coordinates and colors are assigned to what is "missing" in the stream. This is why for these flags, the code is identical except for the assignments in the first "row". (Same principle as in mozilla#6304). Note that this change will not improve the lamp_cairo.pdf file, only the two files mentioned in mozilla#6305.
Short story: somebody got lost in two different indices. pi is an index in the stream and is explained on page 198 of the 32000-spec (however 1-based there), and ps is an index to something in PDF.js. I used the code from flag 0 (which works) to understand which is which. It is also important to understand that for flags 1,2 and 3, the stream is always assigned to the same coordinates and colors. What changes is which "old" coordinates and colors are assigned to what is "missing" in the stream. This is why for these flags, the code is identical except for the assignments in the first "row".
Largely fixes #4227.