Ensure that Dict_getArray doesn't fail if xref in undefined (PR 6485 follow-up)
#6528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…485 follow-up) In PR 6485 I somehow missed to account for the case where `xref` is undefined. Since a dictonary can be initialized without providing a reference to an `xref` instance, `Dict_getArray` can thus fail without this added check.
|
/botio test |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://107.22.172.223:8877/6e337fe38438fc0/output.txt |
From: Bot.io (Linux)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://107.21.233.14:8877/27cc19816b8beac/output.txt |
From: Bot.io (Windows)SuccessFull output at http://107.22.172.223:8877/6e337fe38438fc0/output.txt Total script time: 18.77 mins
|
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/27cc19816b8beac/output.txt Total script time: 19.83 mins
|
timvandermeij
added a commit
that referenced
this pull request
Oct 15, 2015
Ensure that `Dict_getArray` doesn't fail if `xref` in undefined (PR 6485 follow-up)
|
Looks good, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In PR #6485 I somehow missed to account for the case where
xrefis undefined. Since a dictonary can be initialized without providing a reference to anxrefinstance,Dict_getArraycan thus fail without this added check.