Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes incorrect PDF file font metrics. #6601

Merged
merged 1 commit into from
Nov 7, 2015

Conversation

yurydelendik
Copy link
Contributor

The PDF lies about font metrics in font descriptors, e.g. PDF file from #4339 http://www.nasa.gov/pdf/750614main_NASA_FY_2014_Budget_Estimates-508.pdf . It's noticeable in the text layer.

Font HJMTJJ+TimesNewRoman report in PDF Ascent=1026/1000 and Descent=-307/1000, but the font hhea Ascent=1638/2048 and Descent = -410/2048.

screen shot 2015-11-06 at 2 52 16 pm

@yurydelendik
Copy link
Contributor Author

/botio test

@pdfjsbot
Copy link

pdfjsbot commented Nov 6, 2015

From: Bot.io (Linux)


Received

Command cmd_test from @yurydelendik received. Current queue size: 0

Live output at: http://107.21.233.14:8877/8c4d3708d8d1449/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Nov 6, 2015

From: Bot.io (Windows)


Received

Command cmd_test from @yurydelendik received. Current queue size: 0

Live output at: http://107.22.172.223:8877/1f09af14d8372b8/output.txt

@Snuffleupagus
Copy link
Collaborator

This also seems to fix #4665, nicely done!

@pdfjsbot
Copy link

pdfjsbot commented Nov 6, 2015

From: Bot.io (Windows)


Failed

Full output at http://107.22.172.223:8877/1f09af14d8372b8/output.txt

Total script time: 18.79 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: FAILED

Image differences available at: http://107.22.172.223:8877/1f09af14d8372b8/reftest-analyzer.html#web=eq.log

@pdfjsbot
Copy link

pdfjsbot commented Nov 6, 2015

From: Bot.io (Linux)


Failed

Full output at http://107.21.233.14:8877/8c4d3708d8d1449/output.txt

Total script time: 19.64 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: FAILED

Image differences available at: http://107.21.233.14:8877/8c4d3708d8d1449/reftest-analyzer.html#web=eq.log

@brendandahl
Copy link
Contributor

/botio makeref

@pdfjsbot
Copy link

pdfjsbot commented Nov 6, 2015

From: Bot.io (Linux)


Received

Command cmd_makeref from @brendandahl received. Current queue size: 0

Live output at: http://107.21.233.14:8877/4d43a9096460882/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Nov 6, 2015

From: Bot.io (Windows)


Received

Command cmd_makeref from @brendandahl received. Current queue size: 0

Live output at: http://107.22.172.223:8877/3c9015bddc28ae8/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Nov 6, 2015

From: Bot.io (Windows)


Success

Full output at http://107.22.172.223:8877/3c9015bddc28ae8/output.txt

Total script time: 19.42 mins

  • Lint: Passed
  • Make references: Passed
  • Check references: Passed

@pdfjsbot
Copy link

pdfjsbot commented Nov 6, 2015

From: Bot.io (Linux)


Success

Full output at http://107.21.233.14:8877/4d43a9096460882/output.txt

Total script time: 19.99 mins

  • Lint: Passed
  • Make references: Passed
  • Check references: Passed

@yurydelendik
Copy link
Contributor Author

Assuming that intent of makeref was to land the patch, merging... thanks

@a0preetham
Copy link
Contributor

Can you please pull #7046 as well ? This is a small fix to handle the overrides when descent/yMin is zero. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants