-
Notifications
You must be signed in to change notification settings - Fork 10k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Let Travis lint using node make lint
, instead of a hard-coded command
#6733
Let Travis lint using node make lint
, instead of a hard-coded command
#6733
Conversation
Please notice that in umd patch I changed make.js to return an error code in case of failure. You can move that in this PR. |
This looks good to me. I'm not sure exactly why it is still a work in progress, i.e., what else needs to be done? I'm also fine with doing the error code handling in another PR as it seems a bit unrelated here, though I might be mistaken. |
Error code is what let Travis know if linting failed. Can you try commit with failed js file as a test ? |
I see, the |
I did try that previously, and it seemed to work as expected: https://travis-ci.org/mozilla/pdf.js/builds/95454119. But I suppose it can't hurt to do this more explicitly, so I'll push an updated patch! |
Build where linting fails: https://travis-ci.org/mozilla/pdf.js/builds/95986147. |
Let's also check that this doesn't mess with the lint command on e.g. the bots. /botio lint |
From: Bot.io (Windows)ReceivedCommand cmd_lint from @Snuffleupagus received. Current queue size: 0 Live output at: http://107.22.172.223:8877/d2b76322b2df932/output.txt |
From: Bot.io (Linux)ReceivedCommand cmd_lint from @Snuffleupagus received. Current queue size: 0 Live output at: http://107.21.233.14:8877/723ae864bf7e808/output.txt |
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/723ae864bf7e808/output.txt Total script time: 0.93 mins
|
From: Bot.io (Windows)SuccessFull output at http://107.22.172.223:8877/d2b76322b2df932/output.txt Total script time: 1.37 mins
|
Let Travis lint using `node make lint`, instead of a hard-coded command
Nice, thank you! |
Re: #6683 (comment).
This seems to work fine locally when running
npm test
, let's see if Travis agrees.