Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reset the styleElement when clearing out loaded fonts (bug 1232071) #6745

Merged
merged 1 commit into from
Dec 12, 2015
Merged

Reset the styleElement when clearing out loaded fonts (bug 1232071) #6745

merged 1 commit into from
Dec 12, 2015

Conversation

Snuffleupagus
Copy link
Collaborator

@timvandermeij
Copy link
Contributor

What a coincidence, I was just about to report this too. I did not notice it on Windows yet, but I did notice this on Arch Linux while browsing PDFs. I also had the styleSheet is null warning in the console.

@Snuffleupagus
Copy link
Collaborator Author

I did not notice it on Windows yet, but I did notice this on Arch Linux while browsing PDFs.

If you're using the addon, then you'll not hit this error if the Font Loading API is enabled in the browser (see layout.css.font-loading-api.enabled in about:config). However, note that the MOZCENTRAL specific code in font_loader.js is hard-coded not to use that API.

yurydelendik added a commit that referenced this pull request Dec 12, 2015
Reset the `styleElement` when clearing out loaded fonts (bug 1232017)
@yurydelendik yurydelendik merged commit 4485c79 into mozilla:master Dec 12, 2015
@yurydelendik
Copy link
Contributor

Thank you for the patch

@Snuffleupagus Snuffleupagus deleted the bug-1232071 branch December 12, 2015 18:45
@Snuffleupagus Snuffleupagus changed the title Reset the styleElement when clearing out loaded fonts (bug 1232017) Reset the styleElement when clearing out loaded fonts (bug 1232071) Dec 12, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants