Adjust a comment discussing transferred ArrayBuffers, to refer to those buffers being detached, not neutered (consistent with bug 1079844) #6934
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e buffers being detached, not neutered. This change makes the comment consistent with terminology used in the ECMAScript specification.
yurydelendik
added a commit
that referenced
this pull request
Jan 28, 2016
Adjust a comment discussing transferred ArrayBuffers, to refer to those buffers being detached, not neutered
|
Thank you. Can you mention bug number in the PR title? |
jswalden
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes the comment consistent with terminology used in the ECMAScript specification. (I made this change in mozilla-central yesterday for very nearly all other code in the tree, just cleaning up this imported loose end.)
Note that
imgArrayis a typed array, but the spec refers to detachment as a concept applicable toArrayBufferonly. There is no special terminology to describe anArrayBufferview that views a detached buffer. Hence referring toimgArray's buffer being detached, not toimgArrayitself being detached.