-
Notifications
You must be signed in to change notification settings - Fork 10k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Get rid of getAll
usage in colorspace.js
#6975
Get rid of getAll
usage in colorspace.js
#6975
Conversation
For the `CalGray`/`CalRGB`/`Lab` colour spaces, we're currently using `getAll` to retrieve the parameters. However that's not really necessary, since we may just as well explicitly `get` the needed parameters instead.
/botio test |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 1 Live output at: http://107.22.172.223:8877/771344683843d01/output.txt |
From: Bot.io (Linux)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 1 Live output at: http://107.21.233.14:8877/f27ced6378e5a3f/output.txt |
From: Bot.io (Windows)SuccessFull output at http://107.22.172.223:8877/771344683843d01/output.txt Total script time: 20.19 mins
|
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/f27ced6378e5a3f/output.txt Total script time: 21.23 mins
|
/botio-linux preview |
From: Bot.io (Linux)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 0 Live output at: http://107.21.233.14:8877/c023802fb5fb834/output.txt |
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/c023802fb5fb834/output.txt Total script time: 0.81 mins Published |
Get rid of `getAll` usage in colorspace.js
Looks good, thanks! |
For the
CalGray
/CalRGB
/Lab
colour spaces, we're currently usinggetAll
to retrieve the parameters. However that's not really necessary, since we may just as well explicitlyget
the needed parameters instead.