Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of getAll usage in colorspace.js #6975

Merged
merged 1 commit into from
Feb 11, 2016
Merged

Get rid of getAll usage in colorspace.js #6975

merged 1 commit into from
Feb 11, 2016

Conversation

Snuffleupagus
Copy link
Collaborator

For the CalGray/CalRGB/Lab colour spaces, we're currently using getAll to retrieve the parameters. However that's not really necessary, since we may just as well explicitly get the needed parameters instead.

For the `CalGray`/`CalRGB`/`Lab` colour spaces, we're currently using `getAll` to retrieve the parameters. However that's not really necessary, since we may just as well explicitly `get` the needed parameters instead.
@Snuffleupagus
Copy link
Collaborator Author

/botio test

@pdfjsbot
Copy link

From: Bot.io (Windows)


Received

Command cmd_test from @Snuffleupagus received. Current queue size: 1

Live output at: http://107.22.172.223:8877/771344683843d01/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux)


Received

Command cmd_test from @Snuffleupagus received. Current queue size: 1

Live output at: http://107.21.233.14:8877/f27ced6378e5a3f/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)


Success

Full output at http://107.22.172.223:8877/771344683843d01/output.txt

Total script time: 20.19 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: Passed

@pdfjsbot
Copy link

From: Bot.io (Linux)


Success

Full output at http://107.21.233.14:8877/f27ced6378e5a3f/output.txt

Total script time: 21.23 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: Passed

@timvandermeij
Copy link
Contributor

/botio-linux preview

@pdfjsbot
Copy link

From: Bot.io (Linux)


Received

Command cmd_preview from @timvandermeij received. Current queue size: 0

Live output at: http://107.21.233.14:8877/c023802fb5fb834/output.txt

timvandermeij added a commit that referenced this pull request Feb 11, 2016
Get rid of `getAll` usage in colorspace.js
@timvandermeij timvandermeij merged commit 1f49e7b into mozilla:master Feb 11, 2016
@timvandermeij
Copy link
Contributor

Looks good, thanks!

@Snuffleupagus Snuffleupagus deleted the ColorSpace-remove-getAll branch February 11, 2016 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants