Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes insertion of blank pages during print if page sizes differ #7005

Merged
merged 2 commits into from
Mar 24, 2016
Merged

Conversation

tbtlr
Copy link
Contributor

@tbtlr tbtlr commented Feb 18, 2016

@yurydelendik
Copy link
Contributor

I wonder if we can just get away with #printContainer and #printContainer > div height:100% attribute.

Not sure what kind of affect setting of the canvas'es style width/height will have on mozPrintCallback polyfill for other browsers. I wish we could set real size of the paper here in inches or mm.

@tbtlr
Copy link
Contributor Author

tbtlr commented Feb 18, 2016

We probably can once https://bugzilla.mozilla.org/show_bug.cgi?id=851937 is fixed. On my plate.

@timvandermeij
Copy link
Contributor

I confirm that this fixes the mentioned Bugzilla issues. Furthermore it fixes #4041 too. However, it regresses #6461 (more specifically, this file from that issue: https://www.dropbox.com/s/6lves3ge8s2u48g/bedcard.pdf?dl=0) as it stretches it to match 100% height.

@tobytailor Could you look into what is causing this?

@tbtlr
Copy link
Contributor Author

tbtlr commented Mar 21, 2016

@timvandermeij fixed via 708895f.

@timvandermeij
Copy link
Contributor

/botio-linux preview

@pdfjsbot
Copy link

From: Bot.io (Linux)


Received

Command cmd_preview from @timvandermeij received. Current queue size: 0

Live output at: http://107.21.233.14:8877/ce4065b613b1c8c/output.txt

@timvandermeij timvandermeij merged commit da8e345 into mozilla:master Mar 24, 2016
@timvandermeij
Copy link
Contributor

Thank you for the patch!

(I have tested this with IE, Edge, Firefox and Chrome and found no regressions for all problematic PDF files from older/current issues, only improvements in terms of no more blank pages and improved scaling.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants