Faster unit-tests by using beforeAll/afterAll in api_spec.js
#7133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the API unit-tests, we're currently loading the `basicapi.pdf` before every sub-test in `PDFDocument` and `Page`, which slows down the unit-tests quite a bit. Locally this patch reduces the run time for `gulp unittest` by at least 40% for me.
|
/botio unittest |
From: Bot.io (Windows)ReceivedCommand cmd_unittest from @Snuffleupagus received. Current queue size: 0 Live output at: http://107.22.172.223:8877/095bd6bf6f77305/output.txt |
From: Bot.io (Linux)ReceivedCommand cmd_unittest from @Snuffleupagus received. Current queue size: 0 Live output at: http://107.21.233.14:8877/eee035d932f8138/output.txt |
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/eee035d932f8138/output.txt Total script time: 1.48 mins
|
From: Bot.io (Windows)SuccessFull output at http://107.22.172.223:8877/095bd6bf6f77305/output.txt Total script time: 1.84 mins
|
|
Thank you for the patch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the API unit-tests, we're currently loading the
basicapi.pdfbefore every sub-test inPDFDocumentandPage, which slows down the unit-tests quite a bit.Locally this patch reduces the run time for
gulp unittestby at least 40% for me.