Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug 1260585] Stops bleeding of pattern edges for mesh. #7184

Merged
merged 1 commit into from
Apr 12, 2016

Conversation

yurydelendik
Copy link
Contributor

The issue affects both Firefox and Chrome (not Safari though). Workaround due to how wide spread is the issue: adding transparent edges on all four sides of the pattern.

See https://bugzilla.mozilla.org/show_bug.cgi?id=1260585

@Snuffleupagus
Copy link
Collaborator

/botio test

@pdfjsbot
Copy link

From: Bot.io (Linux)


Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://107.21.233.14:8877/51cc8bc774528b8/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)


Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://107.22.172.223:8877/441dbf84c285047/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)


Failed

Full output at http://107.22.172.223:8877/441dbf84c285047/output.txt

Total script time: 20.21 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: FAILED

Image differences available at: http://107.22.172.223:8877/441dbf84c285047/reftest-analyzer.html#web=eq.log

@pdfjsbot
Copy link

From: Bot.io (Linux)


Failed

Full output at http://107.21.233.14:8877/51cc8bc774528b8/output.txt

Total script time: 22.43 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: FAILED

Image differences available at: http://107.21.233.14:8877/51cc8bc774528b8/reftest-analyzer.html#web=eq.log

@Snuffleupagus
Copy link
Collaborator

Looks good, thank you for the patch!
Also, it's really nice that this patch fixes a couple of existing test-cases :-)

/botio makeref

@pdfjsbot
Copy link

From: Bot.io (Windows)


Received

Command cmd_makeref from @Snuffleupagus received. Current queue size: 0

Live output at: http://107.22.172.223:8877/99b63d2477c26c3/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux)


Received

Command cmd_makeref from @Snuffleupagus received. Current queue size: 0

Live output at: http://107.21.233.14:8877/824250db21e809b/output.txt

@Snuffleupagus Snuffleupagus merged commit 127e6d7 into mozilla:master Apr 12, 2016
@pdfjsbot
Copy link

From: Bot.io (Windows)


Success

Full output at http://107.22.172.223:8877/99b63d2477c26c3/output.txt

Total script time: 20.09 mins

  • Lint: Passed
  • Make references: Passed
  • Check references: Passed

@pdfjsbot
Copy link

From: Bot.io (Linux)


Success

Full output at http://107.21.233.14:8877/824250db21e809b/output.txt

Total script time: 22.00 mins

  • Lint: Passed
  • Make references: Passed
  • Check references: Passed

@SamyCookie
Copy link

In reftest analyzer, I see extra pixels on last image row (firefox-issue4227-page1 for example). They are not displayed in other viewers (okular on Debian for example). It may be a rounding issue.

@yurydelendik yurydelendik deleted the pad-mesh branch April 12, 2016 14:35
@yurydelendik
Copy link
Contributor Author

It may be a rounding issue.

It's rounding issue, yes. When triangles are painted, it's doing it in int numbers. The result will depend on scale too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants