Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Dict_getArray in more places in src/core/ to avoid issues when Arrays contain indirect objects #7295

Merged
merged 1 commit into from
May 10, 2016
Merged

Use Dict_getArray in more places in src/core/ to avoid issues when Arrays contain indirect objects #7295

merged 1 commit into from
May 10, 2016

Commits on May 5, 2016

  1. Use Dict_getArray in more places in src/core/ to avoid issues whe… 

    …n Arrays contain indirect objects

As evident from e.g. PRs 6485 and 7118, some bad PDF generators unfortunately create Arrays where *some* elements are indirect objects (i.e. `Ref`s). This seems to mostly affect Arrays that contain numbers, such as e.g. `Matrix/FontMatrix/BBox/FontBBox/Rect/Color/...`, and has manifested itself in PDF files that fail to render correctly (some elements are missing).

The problem in both the cases above, besides broken rendering, was that there were *no* errors/warnings that indicated what the problem was, making it difficult to pinpoint the issue.
Hence this patch, where I've audited all usages of `Dict_get` in `src/core/` files, and replaced it with `Dict_getArray` where appropriate to try and prevent unnecessary future bugs.
    @Snuffleupagus
    Snuffleupagus committed May 5, 2016
    Configuration menu
    Copy the full SHA
    6111c17 View commit details
    Browse the repository at this point in the history