Add support for ResetForm Action #7412
Conversation
| if (data.fieldType === 'Btn' && dict.get('A') !== undefined) { | ||
| var actionRef = dict.map.A.num; | ||
| var xrefObject = dict.xref.fetchIfRef(dict.map.A); | ||
| data.formAction = {}; |
There was a problem hiding this comment.
This formAction property seems not used in src/ or web/. How does this addition introduce support for the ResetForm action?
There was a problem hiding this comment.
Thanks, this is probably leftover code from something else I was working on. It will be removed.
There was a problem hiding this comment.
No, this is not an unused variable. See line 610. I am then using this code to determine what type of annotation this is. Example code:
if (item.formAction.S === "ResetForm") {
There was a problem hiding this comment.
I can see that you're setting another property on data, but what I'm saying is that after setting the property, the property is not used elsewhere.
Taken in isolation, it seems that this extra property doesn't do anything. It is not documented anywhere as far as I can tell, and neither used by the pdf.js code (web/ and src/).
There was a problem hiding this comment.
Yes, I understand that. You are correct that it is not used in web/ or src/. The only place it would be used is in the examples/acroforms. Would you like me to update the code in examples/acroforms? It is my understanding that this pull request is on hold until #6172 is landed. Please let me know how you would like to proceed.
There was a problem hiding this comment.
I concur, let's wait until #6172 lands.
|
Since there are many types of We should probably review/land #6172 first so it can be a basis for this PR. Unfortunately I do not have time at the moment to do so... |
|
@timvandermeij: I wasn't aware of #6172. I was trying to solve a specific issue where I work, hence my smaller and very specific pull requests. I agree that a reusable structure would be preferred, but I didn't have the bandwidth to create something as comprehensive as #6172. Clearly there is a need for these features, and I would like to see #6172 be a higher priority. If #6172 is landed and covers the functionality that I need in my project, then there is no need for my pull requests. Thanks for informing me about #6172. |
jsawruk
force-pushed
the
reset-form-action
branch
from
b968acd
to
7782418
Compare
|
Closing as incomplete. We are tracking this in #7613. Form actions have not been implemented yet and therefore this PR currently has no effect. The structure required for this is not yet in place, but will require code changes. This PR may be used as inspiration for future PRs attempting to implement this behaviour, but in its current state we cannot merge it. |
See PDF 32000-1:2008, 12.7.5.3 Reset-Form Action (p. 455).
This will be used to support clearing a form's values when viewing a form using pdf.js. It will enhance the functionality of the pdf.js acroforms demo (examples/acroforms).