Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that the necessary src/* dependencies are loaded before the viewer, when it's run with gulp server (issue 7448) #7455

Merged
merged 1 commit into from
Jul 8, 2016

Conversation

Snuffleupagus
Copy link
Collaborator

Fixes #7448.

…ewer, when it's run with `gulp server` (issue 7448)

Fixes 7448.
@yurydelendik
Copy link
Contributor

I wonder if we can just add dependency on pdfjs-web/pdfjs for modules that use polyfilled stuff (and provide comments why we do that).

@Snuffleupagus
Copy link
Collaborator Author

I wonder if we can just add dependency on pdfjs-web/pdfjs for modules that use polyfilled stuff (and provide comments why we do that).

I did consider doing that, but then I figured that since we use Promise in a lot of files, we'd technically need to require the pdfjs-web/pdfjs module in lots of places. Currently there's just one breaking issue (in preferences.js), but that seems more like a happy coincidence, so I figured why not solve this in one place such this issue won't come up somewhere else in the future.

@yurydelendik
Copy link
Contributor

yurydelendik commented Jun 29, 2016

Okay, let's go for your original solution. I'm afraid it might bite us again when we start using different bundler. I'm thinking we shall have something like polyfill module that will export Promise and URL and use these.

@yurydelendik yurydelendik merged commit b876760 into mozilla:master Jul 8, 2016
@yurydelendik
Copy link
Contributor

Thank you for the patch

@Snuffleupagus Snuffleupagus deleted the issue-7448 branch July 8, 2016 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants