Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consolidate updating of various Toolbar state (e.g. page and scale) in one method in PDFViewerApplication #7457

Closed
wants to merge 1 commit into from
Closed

Consolidate updating of various Toolbar state (e.g. page and scale) in one method in PDFViewerApplication #7457

wants to merge 1 commit into from

Commits on Jun 29, 2016

  1. Consolidate updating of various Toolbar state (e.g. page and scale) i… 

    …n one method in `PDFViewerApplication`

With the changes in PR 7289, we no longer dispatch a 'pagechanging' event on load. Since most PDF documents open on the first page, this means that the `previous` and `firstPage` buttons are no longer correctly disabled.
To avoid this, this patch moves the code that updates various UI toolbar state into one method, which is then called on document initialization and from the various existing event handling functions.
    @Snuffleupagus
    Snuffleupagus committed Jun 29, 2016
    Configuration menu
    Copy the full SHA
    ce10ac5 View commit details
    Browse the repository at this point in the history